From dev-return-37369-archive-asf-public=cust-asf.ponee.io@subversion.apache.org Tue Jan 16 10:36:49 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id BF90918065B for ; Tue, 16 Jan 2018 10:36:49 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id AFCCA160C34; Tue, 16 Jan 2018 09:36:49 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id ECC7B160C26 for ; Tue, 16 Jan 2018 10:36:48 +0100 (CET) Received: (qmail 71997 invoked by uid 500); 16 Jan 2018 09:36:48 -0000 Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@subversion.apache.org Received: (qmail 71987 invoked by uid 99); 16 Jan 2018 09:36:47 -0000 Received: from mail-relay.apache.org (HELO mail-relay.apache.org) (140.211.11.15) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 16 Jan 2018 09:36:47 +0000 Received: from [192.168.1.2] (unknown [81.174.159.228]) by mail-relay.apache.org (ASF Mail Server at mail-relay.apache.org) with ESMTPSA id A1D161A00E2 for ; Tue, 16 Jan 2018 09:36:45 +0000 (UTC) Subject: Re: 1.10 API review - svn_io_stdin_readline() To: dev@subversion.apache.org References: <20180115212254.GA98299@ted.stsp.name> <20180116080452.GD98299@ted.stsp.name> From: Julian Foad Message-ID: <6c65e43f-d0df-e525-a844-ddc90dd9f2f1@apache.org> Date: Tue, 16 Jan 2018 09:36:42 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20180116080452.GD98299@ted.stsp.name> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit Stefan Sperling wrote: > On Tue, Jan 16, 2018 at 07:37:31AM +0100, Branko Čibej wrote: >> 2. What's wrong with using svn_stream_readline() with >> svn_io_stream_for_stdin2()? >> >> In other words: I suspect this new function should be removed. [...] > > This function is in fact just a convenience wrapper around the two other > functions you mention. > > There are 7 callers of this function across our command line tools. > If this function is not deemed appropriate for the public API, I would just > move it to the libsvn_subr cmdline.c bag of helper functions. Agreed? That is also the thought that came to me overnight. Renamed and moved to svn_cmdline__stdin_readline() in r1821224. Thanks. - Julian