subversion-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Julian Foad <julianf...@apache.org>
Subject Re: svn commit: r1816069 - /subversion/branches/1.8.x-issue4707/subversion/svnrdump/dump_editor.c
Date Wed, 22 Nov 2017 18:11:07 GMT
Evgeny Kotkov wrote:
> Julian Foad <julianfoad@apache.org> writes:
> 
>> -                                ": %lu\n",
>> -                                (unsigned long)info->size));
>> +                                ": %" APR_SIZE_T_FMT "\n",
>> +                                info->size));
> 
> I think that using APR_SIZE_T_FMT would still lead to the same issue with
> large file sizes in the 32-bit environment (where size_t is also 32 bit).
> 
> Perhaps, the code should be using APR_OFF_T_FMT as the format specifier?
> 
> (The apr_file_info_t.size value is an apr_off_t)

Thank you! I will fix it.

- Julian


Mime
View raw message