Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 2C524200CF2 for ; Wed, 9 Aug 2017 00:05:06 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 2AE92168140; Tue, 8 Aug 2017 22:05:06 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 6F29516813F for ; Wed, 9 Aug 2017 00:05:05 +0200 (CEST) Received: (qmail 17774 invoked by uid 500); 8 Aug 2017 22:04:59 -0000 Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@subversion.apache.org Received: (qmail 17764 invoked by uid 99); 8 Aug 2017 22:04:59 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 08 Aug 2017 22:04:59 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id E2624C3D4B for ; Tue, 8 Aug 2017 22:04:58 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -1.048 X-Spam-Level: X-Spam-Status: No, score=-1.048 tagged_above=-999 required=6.31 tests=[KAM_COUK=1.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-2.8, SPF_NEUTRAL=0.652] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id sVgV2HdPJJ8u for ; Tue, 8 Aug 2017 22:04:56 +0000 (UTC) Received: from know-smtprelay-omc-10.server.virginmedia.net (know-smtprelay-omc-10.server.virginmedia.net [80.0.253.74]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id EC1C45F30C for ; Tue, 8 Aug 2017 22:04:55 +0000 (UTC) Received: from localhost ([86.9.48.152]) by know-smtprelay-10-imp with bizsmtp id um4v1v00R3H0lpA01m4vnK; Tue, 08 Aug 2017 23:04:55 +0100 X-Originating-IP: [86.9.48.152] X-Authenticated-User: codematters@ntlworld.com X-Spam: 0 X-Authority: v=2.1 cv=SeoKDalu c=1 sm=1 tr=0 a=rSjZpmdkpCpLRM02tfIJ4Q==:117 a=rSjZpmdkpCpLRM02tfIJ4Q==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=khBPlXF-VzF49OPgidkA:9 a=sz8PhkgltKVSZ_8K:21 a=wJO96ZfzgWmtKQd4:21 From: Philip Martin To: dev@subversion.apache.org Subject: CR in notify.c Date: Tue, 08 Aug 2017 23:04:55 +0100 Message-ID: <87wp6du35k.fsf@codematters.co.uk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain archived-at: Tue, 08 Aug 2017 22:05:06 -0000 When rolling trunk tarballs I notice the error: ../svn/notify.c:483: warning: internationalized messages should not contain the '\r' escape sequence The '\r' is intentional, the notification is of the form: Checking r32... and the \r causes the line to get overwritten as the revision changes. I haven't tested what happens if the revision number gets shorter by lots of digits, but I suspect that if a long first notification: Checking r1234567... is followed by a short second: Checking r99... the first will not be completely obliterated by the second. Perhaps we should move the \r out of the internationalized message and use it in some longer message that is guaranteed to obliterate any previous message. -- Philip