subversion-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Sperling <s...@elego.de>
Subject Re: svn commit: r1801940 - in /subversion/trunk: ./ notes/ subversion/include/ subversion/include/private/ subversion/libsvn_delta/ subversion/libsvn_fs_fs/ subversion/libsvn_subr/ subversion/tests/libsvn_delta/ subversion/tests/libsvn_subr/
Date Wed, 26 Jul 2017 11:50:37 GMT
On Wed, Jul 26, 2017 at 02:41:31PM +0300, Evgeny Kotkov wrote:
> Stefan Sperling <stsp@elego.de> writes:
> 
> > Sounds like we're headed in a good direction :-)
> 
> One particular thing that bothers me about using LZ4 as the new default
> is that I think that a decision like that goes a bit against the usual policy
> (add new optional feature, switch the default in the next minor release).
> 
> But, personally, in this case I would say that it would make sense to
> immediately make LZ4 the new default and available to the users, if there
> won't be objections to that.

If our test suite passes with lz4 I see no reason for concern about
making it the default right away.

> I think that the proposed solution with the new option that overrides (and,
> essentially, deprecates) 'compression-level':
> 
>   compression = none | lz4 | zlib | zlib-1 ... zlib-9
> 
> is explicit and should be understood by the users in case they stumble
> across it.

Makes sense.

> Please note that I don't think that we should change the behavior of
> 'compression-level' in fsfs.conf.  In other words, the 'compression-level'
> would still mean "zlib compression level", exactly as it works now.

Sure. Very explicitly deprecated, please. If an option is marked deprecated
then admins can tell they don't need to waste time thinking about it.

Mime
View raw message