subversion-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel Shahaf <danie...@apache.org>
Subject Re: 1.10.0-alpha3 CHANGES
Date Thu, 20 Jul 2017 10:36:39 GMT
On Wed, Jul 19, 2017 at 05:17:38PM +0100, Philip Martin wrote:
> Daniel Shahaf <d.s@daniel.shahaf.name> writes:
> >> ------------------------------------------------------------------------
> >> r1800836 | philip | 2017-07-04 22:37:52 +0000 (Tue, 04 Jul 2017) | 15 lines
> >> 
> >> Remove some casts when using APR 2 and fix a "missing volatile" bug that
> >> was uncovered.
> 
> This probably doesn't warrent an appearance in CHANGES: it is mostly
> cosmetic.  The compilation unit where the qualifier is visible doesn't
> read the value directly so I think it unlikely the old code misbehaved.

Thanks, Philip.  I'd assumed the worst and added it as "FS: Fix race /
undefined behaviour during FS backend loading (r1800836)".  (Since
accessing a volatile value through a non-volatile-qualified pointer is
UB.)  I'll remove it.

(In retrospect, perhaps I should've waited a bit longer for answers on
this thread.  My bad.)

On Wed, Jul 19, 2017 at 06:11:01PM +0200, Stefan Sperling wrote:
> This is not a change relative 1.9. It just changes the default behaviour
> of the new resolver in a specific use case. No need to mention this.
⋮
> There is no need to mention Makefile.svn in CHANGES, ever.

I didn't mention either of these.

> It is not even shipped in releases.

Actually, it is.  We can patch dist.sh to exclude it.

Cheers,

Daniel

Mime
View raw message