Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 41636200C6F for ; Tue, 9 May 2017 18:52:20 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 403EE160BB6; Tue, 9 May 2017 16:52:20 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 760C3160BC3 for ; Tue, 9 May 2017 18:52:19 +0200 (CEST) Received: (qmail 14812 invoked by uid 500); 9 May 2017 16:52:18 -0000 Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@subversion.apache.org Received: (qmail 13555 invoked by uid 99); 9 May 2017 16:52:18 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 May 2017 16:52:17 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 9296C1A7AFD for ; Tue, 9 May 2017 16:52:17 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.699 X-Spam-Level: X-Spam-Status: No, score=-0.699 tagged_above=-999 required=6.31 tests=[RCVD_IN_DNSWL_LOW=-0.7, UNPARSEABLE_RELAY=0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id xjgqeJBTuOMb for ; Tue, 9 May 2017 16:52:17 +0000 (UTC) Received: from einhorn-mail.in-berlin.de (einhorn-mail.in-berlin.de [217.197.80.20]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 8AB195F36E for ; Tue, 9 May 2017 16:52:16 +0000 (UTC) X-Envelope-From: stsp@elego.de Received: from ted.stsp.name (ted.stsp.name [217.197.84.34]) by einhorn.in-berlin.de (8.14.4/8.14.4/Debian-8+deb8u1) with ESMTP id v49GppJb028157 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 9 May 2017 18:51:51 +0200 Received: from localhost (ted.stsp.name [local]) by ted.stsp.name (OpenSMTPD) with ESMTPA id 63a8e259; Tue, 9 May 2017 18:51:51 +0200 (CEST) Date: Tue, 9 May 2017 18:51:51 +0200 From: Stefan Sperling To: Mark Phippard Cc: Daniel Shahaf , Subversion Development , stefan2@apache.org Subject: Re: [PATCH] reject SHA1 collisions (was: Re: Progress on SHA-1 fixes in patch releases?) Message-ID: <20170509165151.GQ55397@ted.stsp.name> Mail-Followup-To: Mark Phippard , Daniel Shahaf , Subversion Development , stefan2@apache.org References: <20170330174010.GP8941@ted.stsp.name> <20170330193828.GA31530@fujitsu.shahaf.local2> <9afdd120-e539-2c89-6d61-fc87491e01f9@apache.org> <20170418005420.GA6124@fujitsu.shahaf.local2> <20170509093851.GG55397@ted.stsp.name> <20170509113949.GM55397@ted.stsp.name> <20170509132523.GN55397@ted.stsp.name> <20170509154422.GA16567@fujitsu.shahaf.local2> <20170509160824.GP55397@ted.stsp.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.0 (2017-02-23) archived-at: Tue, 09 May 2017 16:52:20 -0000 On Tue, May 09, 2017 at 12:27:40PM -0400, Mark Phippard wrote: > From the best I can tell we have no plan on how or when we could support > this in the working copy. I have also seen a lot of people express > interest in the hook scripts to block the sha1 collisions and not any real > conversation about wanting to fully support storing collisions. With that > in mind, why not just simplify this and say we have no plans to provide > support for supporting two files with the same sha1 and put the code in > place in 1.9.x to block this from happening. This removes the need for > people to add hooks and it solves the problem. Indeed. I have committed this change (with an updated test) in r1794611.