Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm
Precedence: bulk
Subject: Re: [PATCH] add support for zlibstat.lib in install-layout for
 Windows
To: dev@subversion.apache.org
References: <ffe4e775-b132-6659-42ac-9399c1850990@posteo.de>
 <CAB84uBX2hD1Zbcd+GeJpm7djSmXYMH0BtHMaLzYa7i5zJ_EVVQ@mail.gmail.com>
From: Stefan <luke1410@posteo.de>
Message-ID: <5cb06051-31d4-5bf1-8400-92c19b8c7607@posteo.de>
Date: Mon, 20 Feb 2017 02:00:11 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.7.1
MIME-Version: 1.0
In-Reply-To: <CAB84uBX2hD1Zbcd+GeJpm7djSmXYMH0BtHMaLzYa7i5zJ_EVVQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 20 Feb 2017 01:00:22 -0000

On 2/1/2017 11:29, Johan Corveleyn wrote:
> On Wed, Feb 1, 2017 at 3:15 AM, Stefan <luke1410@posteo.de> wrote:
>> Hi,
>>
>> the zlib project's visual studio file creates static libraries named
>> zlibstat.lib by default. Atm SVN supports this, if it determines zlib is
>> in source-layout, but doesn't support it, if it determines files are in
>> install-layout (the detection being based on whether the zlib-path
>> contains an include-directory or not).
>>
>> I think it would be neat, if SVN could handle also the
>> zlibstat.lib-named library (since it's a default name for the static
>> zlib library on Windows). The attached patch adds that support.
>>
>> [[[
>> Add support for zlibstat.lib-named zlib static libraries for Windows
>> builds in
>> install-layout.
>>
>> * build/generator/gen_win_dependencies.py
>>   (_find_zlib): check for zlibstat.lib, when determining the zlib
>> library name
>> ]]]
> +1 on concept (I'll let someone else review the content of the change,
> but it looks sane to me). I've been "bitten" by this lack of support
> before, with some amount of lost time before I figured out what was
> wrong, so anything that helps these kinds of auto-detections is great.
>
Comitted in r1783704.