subversion-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Johan Corveleyn <jcor...@gmail.com>
Subject Re: [PATCH] add support for zlibstat.lib in install-layout for Windows
Date Wed, 01 Feb 2017 10:29:09 GMT
On Wed, Feb 1, 2017 at 3:15 AM, Stefan <luke1410@posteo.de> wrote:
> Hi,
>
> the zlib project's visual studio file creates static libraries named
> zlibstat.lib by default. Atm SVN supports this, if it determines zlib is
> in source-layout, but doesn't support it, if it determines files are in
> install-layout (the detection being based on whether the zlib-path
> contains an include-directory or not).
>
> I think it would be neat, if SVN could handle also the
> zlibstat.lib-named library (since it's a default name for the static
> zlib library on Windows). The attached patch adds that support.
>
> [[[
> Add support for zlibstat.lib-named zlib static libraries for Windows
> builds in
> install-layout.
>
> * build/generator/gen_win_dependencies.py
>   (_find_zlib): check for zlibstat.lib, when determining the zlib
> library name
> ]]]

+1 on concept (I'll let someone else review the content of the change,
but it looks sane to me). I've been "bitten" by this lack of support
before, with some amount of lost time before I figured out what was
wrong, so anything that helps these kinds of auto-detections is great.

-- 
Johan

Mime
View raw message