subversion-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan <luke1...@posteo.de>
Subject Re: [PATCH] Correct indentation in svn_client_conflict_text_resolve_by_id
Date Thu, 10 Nov 2016 22:58:19 GMT
On 11/10/2016 23:37, Daniel Shahaf wrote:
> Stefan wrote on Thu, Nov 10, 2016 at 23:05:18 +0100:
>> On 11/10/2016 10:07, Stefan Sperling wrote:
>>> On Wed, Nov 09, 2016 at 11:21:42PM +0100, Stefan wrote:
>>>> Hi,
>>>>
>>>> attached is a patch to correct indentation in
>>>> svn_client_conflict_text_resolve_by_id() which was spotted by Evgeny
>>>> (related to the mail thread: "svn commit: r1764902 - in
>>>> /subversion/trunk/subversion: libsvn_client/conflicts.c
>>>> svn/conflict-callbacks.c tests/cmdline/resolve_tests.py").
>>>>
>>>> Regards,
>>>> Stefan
>>>>
>>>> [[[
>>>> Following up on r1764902: Corrected indentation.
>>>>
>> Committed in r1769207 with the corrected name.
> A bit late: generally we prefer verbs to be in the imperative, not in
> the passive; i.e.: s/Corrected/Correct/.
>
> It's not too critical to edit this one; just noting this for future
> reference.
>
> Cheers,
>
> Daniel

Corrected anyway.

Regards,
Stefan



Mime
View raw message