subversion-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ivan Zhakov <i...@visualsvn.com>
Subject Re: [PATCH] Reject checkouts to existing directory
Date Fri, 14 Oct 2016 12:40:25 GMT
On 12 October 2016 at 16:28, Patrick Steinhardt
<patrick.steinhardt@elegosoft.com> wrote:
> Hi,
>
> attached is a patch to reject checkouts to already existing
> directories when `--force` is not given. This is according to
> `svn co --help`.
>
> [[
> Reject checkout to existing paths without force
>
> * subversion/svn/checkout-cmd.c:
>   - (svn_cl__checkout): Reject checkout to existing directory
>     without --force
> ]]
>
As far I see we have four different cases of checking out to existing directory:
a. Checkout of non-empty directory to non-empty local directory
b. Checkout of non-empty directory to empty local directory
c. Checkout of empty directory to non-empty local directory
d. Checkout of empty directory to empty local directory

I think that cases (b),(c),(d) should not require '--force'. It seems
to be pretty safe operations. Also (c) is common way to 'takeover'
(version) existing repository. I meant:
1. Create empty directory in repository
2. Check it to existing directory with source code
3. Add all requested files/directories
4. Review all changes and commit.

But it makes sense for to require '--force' flag for case (a): it's
very easy mess up local changes in this situation.

-- 
Ivan Zhakov

Mime
View raw message