subversion-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ivan Zhakov <i...@visualsvn.com>
Subject Re: [PATCH] Fix number of array elements
Date Wed, 12 Oct 2016 10:58:21 GMT
On 12 October 2016 at 12:48, Stefan <luke1410@gmx.de> wrote:
> Hi,
>
> hope this patch is correct... As far as I  see the number of elements is
> off by one here:
>
> [[[
> Allocate the correct number of element entries.
>
> * subversion/libsvn_client/conflicts.c
>   (svn_client_conflict_text_get_resolution_options): Correct number of array
>   entires.
> ]]]
I think that log message could be improvement: because this not the
number of how many entries is allocated. This is initial size of
array, and apr_array will expand it if needed.


PS: Please submit patches with text/plain mime type as recommended in
Community Guide [1]
[1] https://subversion.apache.org/docs/community-guide/general.html#patches-submission


-- 
Ivan Zhakov

Mime
View raw message