subversion-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Patrick Steinhardt <>
Subject [PATCH] Improve conformance to ISO C90
Date Fri, 14 Oct 2016 13:24:10 GMT

attached patch fixes compatibility with ISO C90. It fixes
trailing commas in enum lists as well as one case where variadic
macros are used, which are a feature of C99. What it does not fix
is strings with overlength (C90 only allows for fixed strings
with a maximum length of 509 characters).

This allows us to build the code with `-Werror -pedantic

Improve C90 compatibility by removing trailing commas in enum
lists as well as converting a variadic macro stub with an empty

* subversion/include/svn_client.h:
  (svn_client_config_option_id_t): remove trailing comma
* subversion/include/svn_wc.h:
  (svn_wc_notify_action_t): remove trailing comma
* subversion/libsvn_subr/cache-membuffer.c:
  (prefix_pool_create): remove trailing comma
* subversion/svn/svn.c:
  (svn_cl__longopt_t): remove trailing comma
* subversion/svnmucc/svnmucc.c:
  (sub_main): remove trailing comma
* subversion/svnmover/linenoise/linenouse.c:
  (lndebug): replace variadic macro stub with an empty variadic
Patrick Steinhardt, Entwickler

elego Software Solutions GmbH,
Gebäude 12 (BIG), Gustav-Meyer-Allee 25, 13355 Berlin, Germany

Sitz der Gesellschaft: Berlin, USt-IdNr.: DE 163214194
Handelsregister: Amtsgericht Charlottenburg HRB 77719
Geschäftsführer: Olaf Wagner

View raw message