Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm
Precedence: bulk
Subject: Re: [PATCH] Resolve testsuite interruption in SVN 1.8
To: dev@subversion.apache.org
References: <885361ff-0e43-6bd2-0d4f-3d846e72aabc@gmx.de>
 <20160807182358.GD81804@byrne.stsp.name>
 <20160807182704.GE81804@byrne.stsp.name>
 <CABw-3YePrnAHqhFfM2ape4f7dsi1xXOyh30RMRWGW6S70OHc-Q@mail.gmail.com>
From: Stefan <luke1410@posteo.de>
Message-ID: <091a5c0f-66e4-ca50-41b6-de067713d578@posteo.de>
Date: Sun, 7 Aug 2016 22:14:29 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.2.0
MIME-Version: 1.0
In-Reply-To: <CABw-3YePrnAHqhFfM2ape4f7dsi1xXOyh30RMRWGW6S70OHc-Q@mail.gmail.com>
Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="------------ms070305090608020600000005"
archived-at: Sun, 07 Aug 2016 20:15:05 -0000

This is a cryptographically signed message in MIME format.

--------------ms070305090608020600000005
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable

On 8/7/2016 21:16, Ivan Zhakov wrote:
> On 7 August 2016 at 21:27, Stefan Sperling <stsp@elego.de> wrote:
>> On Sun, Aug 07, 2016 at 08:23:58PM +0200, Stefan Sperling wrote:
>>> On Sun, Aug 07, 2016 at 02:08:35PM +0200, Stefan wrote:
>>>> Hi,
>>>>
>>>> the attached patch is the outcome of talking with jcorval on IRC abo=
ut a
>>>> test suite issue on Windows (release builds) in SVN 1.8. It resolves=
 the
>>>> fact that the tests will be interrupted on Windows by a Windows popu=
p
>>>> upon an abort()-call.
>>>>
>>>> Atm this is triggered for the 1.8 test suite for the move-test (no 8=
)
>>>> which is marked as XFail and triggers an SVN_ERR_ASSERT() and theref=
ore
>>>> breaks fully automated tests.
>>> I'm not a windows person but this looks reasonable to me. +1
>> Forgot to mention: If this is a 1.8-only fix, I'd suggest you create
>> a branch of 1.8.x and commit your patch there, and then nominate your
>> branch in the 1.8.x/STATUS file (you can add my +1 to the nomination).=

> I'm not sure that we should add handling of new environment variable
> in patch release.
>
>
I can understand the concern. Please bare in mind however that the
default behavior (aka: if the environment variable is not set) would
stay unchanged and the effect of the environment variable is quite
limited (it will only disable the Watson crash dumps in release builds -
obviously only applies on Windows builds). It's by default only
activated for the test suites and therefore the risks involved is IMO
close to non existent.

Weighting the pros (fixing a test interruption of the test suite for
everybody testing/building the SVN package) with the cons (the risk of
s/o unintentionally already having set an environment variable with the
same name and on the other side introducing a new test-suite related
feature in a patch release which would be not available in versions <=3D
1.8.16), I do have a tendency to still propose that patch. (Note: I
would suggest otherwise, if it wasn't related to a fix for the
testsuite, since then it could hardly be seen as a bugfix).

I thought about alternatives, but rejected them due to different reasons:=


Alternative 1:
Do not use the environment variable and rather make it implicit behavior
to disable the Watson crash reports.
Rejected, since that would be a behavior change of SVN. Downstream
releases of SVN might rely on current crashdump integration and would be
broken.

Alternative 2 (untested):
For the test environment set the corresponding Windows registry entry
[1] prior to running the SVN tests so to disable sending the
crashreports and/or bring up the popup to attach a debugger.
Rejected, since that would be an additional barrier to run the testsuite
especially for people building SVN themselves. IMO there should be as
few hurdles as possible to build and test SVN, so to not risk stopping
people from giving SVN a try.

Alternative 3:
Use a config setting instead of an environment variable.
Rejected, since there we could not disable the crashreports before the
config file was processed.

Alternative 4:
Use a command line parameter to disable crashreports.
Rejected, since it would only work for command line tests but not for
testing the C API.

Maybe your call, Ivan, would be to use alternative 2 for SVN <=3D 1.9 and=

introduce the environment variable related fix in trunk only?

[1]
https://blogs.msdn.microsoft.com/alejacma/2011/02/18/how-to-disable-the-p=
op-up-that-windows-shows-when-an-app-crashes/

Regards,
Stefan


--------------ms070305090608020600000005
Content-Type: application/pkcs7-signature; name="smime.p7s"
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="smime.p7s"
Content-Description: S/MIME Cryptographic Signature

MIAGCSqGSIb3DQEHAqCAMIACAQExDzANBglghkgBZQMEAgEFADCABgkqhkiG9w0BBwEAAKCC
BlowggZWMIIEPqADAgECAgMR/wswDQYJKoZIhvcNAQENBQAweTEQMA4GA1UEChMHUm9vdCBD
QTEeMBwGA1UECxMVaHR0cDovL3d3dy5jYWNlcnQub3JnMSIwIAYDVQQDExlDQSBDZXJ0IFNp
Z25pbmcgQXV0aG9yaXR5MSEwHwYJKoZIhvcNAQkBFhJzdXBwb3J0QGNhY2VydC5vcmcwHhcN
MTYwNTAxMDAyNTQ5WhcNMTYxMDI4MDAyNTQ5WjCByjEYMBYGA1UEAxMPQ0FjZXJ0IFdvVCBV
c2VyMSEwHwYJKoZIhvcNAQkBFhJsdWtlMTQxMEBwb3N0ZW8uZGUxJDAiBgkqhkiG9w0BCQEW
FXN0ZWZhbi5oZXR0QHBvc3Rlby5kZTEiMCAGCSqGSIb3DQEJARYTbHVrZTE0MTBAYXBhY2hl
Lm9yZzEeMBwGCSqGSIb3DQEJARYPbHVrZTE0MTBAZ214LmRlMSEwHwYJKoZIhvcNAQkBFhJz
dGVmYW4uaGV0dEBnbXguZGUwggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAwggEKAoIBAQDe/SbZ
aLYB+CQ8YF79gmmSaPHBd1KAhXqevB8AVjahmEgjq1ue3C0l+Wbe/k0sLYHLDlNOcDyDalZG
+GNpeqqKiSxZinG7XANtpx5RYkQnh59625jR23zSF9C/mnINC1RS3IuH2IC975HUx05xbFNW
TtnKKEHdlKRKIFsCsWp99PtcWuduEOp/7nqL+5yXmum46elzinwcHfvt5gxR2JTCAmKMKrYF
oxWJSjMOGZzcZON8GSiEDk2z+kHVzFa/L+bh4AdyH3tOlebOONfKQ1Gf5Y21ftgUcXGdPxnT
T3dbOPe5Os2LBhiyyv5rquPh+z/CtIPiEBNeY56G7RkRLB1BAgMBAAGjggGTMIIBjzAMBgNV
HRMBAf8EAjAAMFYGCWCGSAGG+EIBDQRJFkdUbyBnZXQgeW91ciBvd24gY2VydGlmaWNhdGUg
Zm9yIEZSRUUgaGVhZCBvdmVyIHRvIGh0dHA6Ly93d3cuQ0FjZXJ0Lm9yZzAOBgNVHQ8BAf8E
BAMCA6gwQAYDVR0lBDkwNwYIKwYBBQUHAwQGCCsGAQUFBwMCBgorBgEEAYI3CgMEBgorBgEE
AYI3CgMDBglghkgBhvhCBAEwMgYIKwYBBQUHAQEEJjAkMCIGCCsGAQUFBzABhhZodHRwOi8v
b2NzcC5jYWNlcnQub3JnMDEGA1UdHwQqMCgwJqAkoCKGIGh0dHA6Ly9jcmwuY2FjZXJ0Lm9y
Zy9yZXZva2UuY3JsMG4GA1UdEQRnMGWBEmx1a2UxNDEwQHBvc3Rlby5kZYEVc3RlZmFuLmhl
dHRAcG9zdGVvLmRlgRNsdWtlMTQxMEBhcGFjaGUub3JngQ9sdWtlMTQxMEBnbXguZGWBEnN0
ZWZhbi5oZXR0QGdteC5kZTANBgkqhkiG9w0BAQ0FAAOCAgEAZShfIncD3YJfsSvnJJm2uYPG
0m771PnZf8Jg17HmC5rJbrQXv5XUEdhUFZExCSNoxap/Sm4prhJbzXw0cm20/jbZ5Nn6aZIq
aDkcGPxb1gxIi+/QJYj/6gWrKhMi2M4a+m1GL/QRaCQGwX/UHHQiHQtezk/JjvhI6mL1n9yF
LSCZyNeIGa5KB2JO4R2e7aVzJJoGd+rGD4NFFtW5pvoOHJZ6SFsnHwMfwDJZSaw5Er2KLtCG
my0lbJK3aUvX0wltiIkOB46QpyRrifqOYHZ33bJUYDMfDybYNFJK9aVXfK037g4Oi+Mo6Oai
LKNCt2u4zYie46NHJRkFVCdeQ9yDn9NAjprM8qqffXINF2PEqZe3HsCF1+5yL5s3LPZvgZHw
I3AVssknupsloG67SzoftErSdDGkauF5xVKH8xe5fex/0izYfqH0UI1lusA8TiuTOz4oF7nj
niA/3hN7pWl9ahGCreM6FQ0qiAUB2dKeW6dkD4FDKNhgXhQlG186L9oKwWVsIQ7JCVUoF8ls
hTwtT0SGwsYhSYAXnsTEzcMjcjxipy6hRt6MSdmdsqNsK7+sxMm0gNtC8HpMKZUZyduwmAkb
77UU/XE6UyP9LvWVoMw3biEb8tM1KaWO7xnTIzVEEbk4yp3weJNbDYqy9NXSGOZTz1RZ9iB+
/LCMuJ/lfEkxggOxMIIDrQIBATCBgDB5MRAwDgYDVQQKEwdSb290IENBMR4wHAYDVQQLExVo
dHRwOi8vd3d3LmNhY2VydC5vcmcxIjAgBgNVBAMTGUNBIENlcnQgU2lnbmluZyBBdXRob3Jp
dHkxITAfBgkqhkiG9w0BCQEWEnN1cHBvcnRAY2FjZXJ0Lm9yZwIDEf8LMA0GCWCGSAFlAwQC
AQUAoIICATAYBgkqhkiG9w0BCQMxCwYJKoZIhvcNAQcBMBwGCSqGSIb3DQEJBTEPFw0xNjA4
MDcyMDE0MjlaMC8GCSqGSIb3DQEJBDEiBCB8XYkgFejhu8Hk6jLzVC+WKRsK4gbaX1q7ejWA
7j5g+jBsBgkqhkiG9w0BCQ8xXzBdMAsGCWCGSAFlAwQBKjALBglghkgBZQMEAQIwCgYIKoZI
hvcNAwcwDgYIKoZIhvcNAwICAgCAMA0GCCqGSIb3DQMCAgFAMAcGBSsOAwIHMA0GCCqGSIb3
DQMCAgEoMIGRBgkrBgEEAYI3EAQxgYMwgYAweTEQMA4GA1UEChMHUm9vdCBDQTEeMBwGA1UE
CxMVaHR0cDovL3d3dy5jYWNlcnQub3JnMSIwIAYDVQQDExlDQSBDZXJ0IFNpZ25pbmcgQXV0
aG9yaXR5MSEwHwYJKoZIhvcNAQkBFhJzdXBwb3J0QGNhY2VydC5vcmcCAxH/CzCBkwYLKoZI
hvcNAQkQAgsxgYOggYAweTEQMA4GA1UEChMHUm9vdCBDQTEeMBwGA1UECxMVaHR0cDovL3d3
dy5jYWNlcnQub3JnMSIwIAYDVQQDExlDQSBDZXJ0IFNpZ25pbmcgQXV0aG9yaXR5MSEwHwYJ
KoZIhvcNAQkBFhJzdXBwb3J0QGNhY2VydC5vcmcCAxH/CzANBgkqhkiG9w0BAQEFAASCAQBF
2+9xe3CoYyPdI2+IceVOOT6aqnHErJy3X/Ww7fNb5VjlROHvai4HwDMzLDbPtGu+k2FhYwuU
ypi/ZscOTEk94dRsnvXIjOk4mJof7HuIpEJI65K4miBi91ZI8gzhW7o7T3hBcrSiHcrVLJv1
ojOEAf5DyFvIu0RE/OJiJGlgBd90HBhXuINiwXXeQRJFWmTOneBWdwVNItAu19nJtOJF/nse
D6smaTku7BtAWyV+40F2z082xGIC5QtNCrPG4lyygokTulNhQ+eRrLHShUGYydQ6hc5GrXWF
bUjN80ffUDaTGGLys4MyfFIHEXD3yTYpfzNYGO9Ibqg3RvwWkf2GAAAAAAAA
--------------ms070305090608020600000005--