subversion-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel Shahaf <...@daniel.shahaf.name>
Subject Re: [PATCH] Fix for access violation in svn_fs__path_valid()
Date Sun, 07 Feb 2016 00:22:06 GMT
Stefan wrote on Mon, Feb 01, 2016 at 00:34:32 +0100:
> +++ fs-loader.c	(working copy)
> @@ -461,7 +461,8 @@
>    if (! svn_utf__cstring_is_valid(path))
>      {
>        return svn_error_createf(SVN_ERR_FS_PATH_SYNTAX, NULL,
> -                               _("Path '%s' is not in UTF-8"), path);
> +                               _("Path '%s' is not in UTF-8"),
> +                               path ? path : "NULL");

Is this actually a problem?  svn_error_createf() uses apr_pvsprintf()
which (by code inspection) accepts NULL here.

Mime
View raw message