subversion-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Evgeny Kotkov <evgeny.kot...@visualsvn.com>
Subject Re: svn commit: r1723900 - in /subversion/branches/fs-node-api/subversion: include/svn_fs.h libsvn_fs/fs-loader.c libsvn_fs/fs-loader.h libsvn_fs/node_compat.c libsvn_fs_fs/node.c tests/libsvn_fs/fs-test.c
Date Mon, 11 Jan 2016 10:55:13 GMT
Bert Huijben <bert@qqmail.nl> writes:

> A quick review showed one minor issue, see inline.

[...]

>> @@ -2399,6 +2422,17 @@ svn_fs_file_length(svn_filesize_t *lengt
>>   * @since New in 1.6.
>>   */
>>  svn_error_t *
>> +svn_fs_file_checksum2(svn_checksum_t **checksum,
>> +                      svn_checksum_kind_t kind,
>> +                      svn_fs_node_t *root,
>> +                      svn_boolean_t force,
>> +                      apr_pool_t *pool);
>
> Wrong argument name here.
> (And the @since should have moved to the legacy function, etc.)

Thanks for the review.  Should be fixed by r1724002 and r1724003.


Regards,
Evgeny Kotkov

Mime
View raw message