Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm
Precedence: bulk
From: Philip Martin <philip@codematters.co.uk>
To: "Bert Huijben" <bert@qqmail.nl>
Cc: 'Branko =?utf-8?Q?=C4=8Cibej'?= <brane@apache.org>,
  <dev@subversion.apache.org>
Subject: Re: svn commit: r1716548 -
 /subversion/trunk/subversion/tests/libsvn_fs/fs-test.c
References: <20151125213120.9C7FE3A02EE@svn01-us-west.apache.org>
	<010901d127d0$81dadc60$85909520$@qqmail.nl>
	<5656395A.60807@apache.org>
	<011601d127d7$8def30d0$a9cd9270$@qqmail.nl>
	<87610olvpc.fsf@wandisco.com> <871tbclj6k.fsf@wandisco.com>
Date: Thu, 26 Nov 2015 18:36:55 +0000
In-Reply-To: <871tbclj6k.fsf@wandisco.com> (Philip Martin's message of "Thu,
	26 Nov 2015 18:17:07 +0000")
Message-ID: <87wpt4k3p4.fsf@codematters.co.uk>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain

Philip Martin <philip.martin@wandisco.com> writes:

> Philip Martin <philip.martin@wandisco.com> writes:
>
>> I suppose one way to fix this would be to ensure that every BDB revision
>> generates a new node-revision-id.
>
> To do this we make '/' mutable either when creating the txn, or when
> commiting the txn.  Patches to do both below.  Not sure which one is
> best.

Seems like this behaviour had been observed in the past, with one of my
patches we also need to stop special-casing BDB in ra-tests:

Index: subversion/tests/libsvn_ra/ra-test.c
===================================================================
--- subversion/tests/libsvn_ra/ra-test.c	(revision 1716725)
+++ subversion/tests/libsvn_ra/ra-test.c	(working copy)
@@ -1606,12 +1606,7 @@ commit_empty_last_change(const svn_test_opts_t *op
     SVN_TEST_ASSERT(dirent != NULL);
     SVN_TEST_STRING_ASSERT(dirent->last_author, "jrandom");
 
-    /* BDB only updates last_changed on the repos_root when there is an
-       actual change. Our other filesystems handle this differently */
-    if (!opts->fs_type || !strcasecmp(opts->fs_type, "BDB"))
-        SVN_TEST_ASSERT(dirent->created_rev == 1);
-    else
-        SVN_TEST_ASSERT(dirent->created_rev == 2);
+    SVN_TEST_ASSERT(dirent->created_rev == 2);
 
     return SVN_NO_ERROR;
 }


-- 
Philip