Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm
Precedence: bulk
From: "Bert Huijben" <bert@qqmail.nl>
To: "'Ivan Zhakov'" <ivan@visualsvn.com>,
	<dev@subversion.apache.org>
References: <20151123142959.C46DF3A03E8@svn01-us-west.apache.org>
 <CABw-3YfTyo3mV-cLxL-g8jcHb_D1upk2qEskSwoY+UUREyLD_g@mail.gmail.com>
In-Reply-To: 
 <CABw-3YfTyo3mV-cLxL-g8jcHb_D1upk2qEskSwoY+UUREyLD_g@mail.gmail.com>
Subject: RE: svn commit: r1715832 - /subversion/trunk/win-tests.py
Date: Mon, 23 Nov 2015 16:08:28 +0100
Message-ID: <026c01d12600$cf10b850$6d3228f0$@qqmail.nl>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQIt/a4jOvkWY+igu5AhASGH/61SsAIy6GrYnd5umaA=
Content-Language: nl


> -----Original Message-----
> From: Ivan Zhakov [mailto:ivan@visualsvn.com]
> Sent: maandag 23 november 2015 15:31
> To: dev@subversion.apache.org; Bert Huijben <bert@qqmail.nl>
> Subject: Re: svn commit: r1715832 - /subversion/trunk/win-tests.py
>=20
> On 23 November 2015 at 17:29,  <rhuijben@apache.org> wrote:
> > Author: rhuijben
> > Date: Mon Nov 23 14:29:59 2015
> > New Revision: 1715832
> >
> > URL: http://svn.apache.org/viewvc?rev=3D1715832&view=3Drev
> > Log:
> > * win-tests.py
> >   (Svnserve.start): Pass the SVN_DBG_STACKTRACES_TO_STDERR
> environment
> >     variable to svnserve.exe to get more information on crashes on =
testruns.
> >
> > Modified:
> >     subversion/trunk/win-tests.py
> >
> > Modified: subversion/trunk/win-tests.py
> > URL: http://svn.apache.org/viewvc/subversion/trunk/win-
> tests.py?rev=3D1715832&r1=3D1715831&r2=3D1715832&view=3Ddiff
> >
> =
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> > --- subversion/trunk/win-tests.py (original)
> > +++ subversion/trunk/win-tests.py Mon Nov 23 14:29:59 2015
> > @@ -447,7 +447,9 @@ class Svnserve:
> [...]
>=20
> >      if use_ssl and use_http2:
> > -      fp.write('Protocols h2 http/1.1\n')
> > +      fp.write('Protocols h2\n')
> >      elif use_http2:
> > -      fp.write('Protocols h2c http/1.1\n')
> > +      fp.write('Protocols h2c\n')
> >        fp.write('H2Direct on\n')
> ^^^ Looks like unintended change.

Yes...

Although it isn't as bad as it looks.

Before this patch the server side supported http/1.1 and h2 when you =
enabled http/2. Now it only supports http2 in this mode.

I'll revert this bit.

I added this patch locally as I couldn't believe how many tests were =
passing.


Thanks for your review!

	Bert