subversion-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Philip Martin <phi...@codematters.co.uk>
Subject Re: svn commit: r1716548 - /subversion/trunk/subversion/tests/libsvn_fs/fs-test.c
Date Thu, 26 Nov 2015 18:36:55 GMT
Philip Martin <philip.martin@wandisco.com> writes:

> Philip Martin <philip.martin@wandisco.com> writes:
>
>> I suppose one way to fix this would be to ensure that every BDB revision
>> generates a new node-revision-id.
>
> To do this we make '/' mutable either when creating the txn, or when
> commiting the txn.  Patches to do both below.  Not sure which one is
> best.

Seems like this behaviour had been observed in the past, with one of my
patches we also need to stop special-casing BDB in ra-tests:

Index: subversion/tests/libsvn_ra/ra-test.c
===================================================================
--- subversion/tests/libsvn_ra/ra-test.c	(revision 1716725)
+++ subversion/tests/libsvn_ra/ra-test.c	(working copy)
@@ -1606,12 +1606,7 @@ commit_empty_last_change(const svn_test_opts_t *op
     SVN_TEST_ASSERT(dirent != NULL);
     SVN_TEST_STRING_ASSERT(dirent->last_author, "jrandom");
 
-    /* BDB only updates last_changed on the repos_root when there is an
-       actual change. Our other filesystems handle this differently */
-    if (!opts->fs_type || !strcasecmp(opts->fs_type, "BDB"))
-        SVN_TEST_ASSERT(dirent->created_rev == 1);
-    else
-        SVN_TEST_ASSERT(dirent->created_rev == 2);
+    SVN_TEST_ASSERT(dirent->created_rev == 2);
 
     return SVN_NO_ERROR;
 }


-- 
Philip

Mime
View raw message