Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm
Precedence: bulk
MIME-Version: 1.0
In-Reply-To: 
 <CAEcU=1ZxZ0mEXQeLyTPm58zzHHoXiTpsxuDtYxfcPR-DT5A6Ng@mail.gmail.com>
References: <20151007075707.21F4B3A0046@svn01-us-west.apache.org>
	<4ad801d100f0$8c352820$a49f7860$@qqmail.nl>
	<CABw-3YfmKSXrojMe=VNAWnonJbrKj8YORxxq-JnTjid6qq4Eaw@mail.gmail.com>
	<CAEcU=1a7HpvDQWLr3q0wPU5-2cOfUYA7zb4pDqhjh+wMD4_o2w@mail.gmail.com>
	<CABw-3YdHTeAqrGxWBMnDBdO+zmy7GBX5=2KeLd4LAZjf6w-Upw@mail.gmail.com>
	<CABw-3YcYMz+WvNuCcD9CDdaTAZD8NB4fDyHAbkUc5HcNCovF-g@mail.gmail.com>
	<CAEcU=1ZxZ0mEXQeLyTPm58zzHHoXiTpsxuDtYxfcPR-DT5A6Ng@mail.gmail.com>
Date: Wed, 7 Oct 2015 14:57:59 +0200
Message-ID: 
 <CA+t0gk3VAsrc=dpjN-MrtSaJODM8QtHOnwixMqzyQQ4ugsUGAQ@mail.gmail.com>
Subject: Re: svn commit: r1707196 -
 /subversion/trunk/subversion/libsvn_subr/stream.c
From: Stefan Fuhrmann <stefan.fuhrmann@wandisco.com>
To: Julian Foad <julianfoad@gmail.com>
Cc: Ivan Zhakov <ivan@visualsvn.com>, Bert Huijben <bert@qqmail.nl>,
 dev <dev@subversion.apache.org>
Content-Type: multipart/mixed; boundary=001a113efc82cbc9070521834bdb

--001a113efc82cbc9070521834bdb
Content-Type: multipart/alternative; boundary=001a113efc82cbc9030521834bd9

--001a113efc82cbc9030521834bd9
Content-Type: text/plain; charset=UTF-8

On Wed, Oct 7, 2015 at 2:47 PM, Julian Foad <julianfoad@gmail.com> wrote:

> Stefan wrote:
> > I guess the correct way of doing this is revert Ivan's
> > change and apply something like the attached patch.
> Ivan wrote:
> > Here is the patch that I wanted commit later. What do you think?
>
> I am not interested in reviewing any more patches that tweak just one
> of the implementations. If you (anybody) want to do something, please
> combine the two functions into one implementation, and then I will be
> interested in reviewing the (single) implementation.
>

Alright, here you go.

-- Stefan^2.

--001a113efc82cbc9030521834bd9
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_extra"><div class=3D"gmail_quote">On W=
ed, Oct 7, 2015 at 2:47 PM, Julian Foad <span dir=3D"ltr">&lt;<a href=3D"ma=
ilto:julianfoad@gmail.com" target=3D"_blank">julianfoad@gmail.com</a>&gt;</=
span> wrote:<br><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8e=
x;border-left:1px #ccc solid;padding-left:1ex"><span class=3D"">Stefan wrot=
e:<br>
&gt; I guess the correct way of doing this is revert Ivan&#39;s<br>
&gt; change and apply something like the attached patch.<br>
</span><span class=3D"">Ivan wrote:<br>
&gt; Here is the patch that I wanted commit later. What do you think?<br>
<br>
</span>I am not interested in reviewing any more patches that tweak just on=
e<br>
of the implementations. If you (anybody) want to do something, please<br>
combine the two functions into one implementation, and then I will be<br>
interested in reviewing the (single) implementation.<br></blockquote><div><=
br></div><div>Alright, here you go.<br><br></div><div>-- Stefan^2.<br></div=
></div><br></div></div>

--001a113efc82cbc9030521834bd9--

--001a113efc82cbc9070521834bdb
Content-Type: text/x-diff; charset=US-ASCII;
 name="stringbuf_from_stream.patch"
Content-Disposition: attachment; filename="stringbuf_from_stream.patch"
Content-Transfer-Encoding: base64
X-Attachment-Id: f_ifgsvg4l0

SW5kZXg6IHN1YnZlcnNpb24vbGlic3ZuX3N1YnIvc3RyZWFtLmMKPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gc3Vi
dmVyc2lvbi9saWJzdm5fc3Vici9zdHJlYW0uYwkocmV2aXNpb24gMTcwNjYyOCkKKysrIHN1YnZl
cnNpb24vbGlic3ZuX3N1YnIvc3RyZWFtLmMJKHdvcmtpbmcgY29weSkKQEAgLTE0ODgsNyArMTQ4
OCw3IEBACiB7CiAjZGVmaW5lIE1JTl9SRUFEX1NJWkUgNjQKIAotICBhcHJfc2l6ZV90IHRvX3Jl
YWQgPSAwOworICBhcHJfc2l6ZV90IHRvX3JlYWQsIGdvdHRlbjsKICAgc3ZuX3N0cmluZ2J1Zl90
ICp0ZXh0CiAgICAgPSBzdm5fc3RyaW5nYnVmX2NyZWF0ZV9lbnN1cmUobGVuX2hpbnQgPyBsZW5f
aGludCA6IE1JTl9SRUFEX1NJWkUsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
cmVzdWx0X3Bvb2wpOwpAQCAtMTQ5NiwxMyArMTQ5NiwxNyBAQAogICBkbwogICAgIHsKICAgICAg
IHRvX3JlYWQgPSB0ZXh0LT5ibG9ja3NpemUgLSAxIC0gdGV4dC0+bGVuOwotICAgICAgU1ZOX0VS
Uihzdm5fc3RyZWFtX3JlYWRfZnVsbChzdHJlYW0sIHRleHQtPmRhdGEgKyB0ZXh0LT5sZW4sICZ0
b19yZWFkKSk7Ci0gICAgICB0ZXh0LT5sZW4gKz0gdG9fcmVhZDsKKyAgICAgIGlmICh0b19yZWFk
ID09IDApCisgICAgICAgIHsKKyAgICAgICAgICBzdm5fc3RyaW5nYnVmX2Vuc3VyZSh0ZXh0LCB0
ZXh0LT5ibG9ja3NpemUgKiAyKTsKKyAgICAgICAgICB0b19yZWFkID0gdGV4dC0+YmxvY2tzaXpl
IC0gMSAtIHRleHQtPmxlbjsKKyAgICAgICAgfQogCi0gICAgICBpZiAodG9fcmVhZCAmJiB0ZXh0
LT5ibG9ja3NpemUgPCB0ZXh0LT5sZW4gKyBNSU5fUkVBRF9TSVpFKQotICAgICAgICBzdm5fc3Ry
aW5nYnVmX2Vuc3VyZSh0ZXh0LCB0ZXh0LT5ibG9ja3NpemUgKiAyKTsKKyAgICAgIGdvdHRlbiA9
IHRvX3JlYWQ7CisgICAgICBTVk5fRVJSKHN2bl9zdHJlYW1fcmVhZF9mdWxsKHN0cmVhbSwgdGV4
dC0+ZGF0YSArIHRleHQtPmxlbiwgJmdvdHRlbikpOworICAgICAgdGV4dC0+bGVuICs9IGdvdHRl
bjsKICAgICB9Ci0gIHdoaWxlICh0b19yZWFkKTsKKyAgd2hpbGUgKGdvdHRlbiA9PSB0b19yZWFk
KTsKIAogICB0ZXh0LT5kYXRhW3RleHQtPmxlbl0gPSAnXDAnOwogICAqc3RyID0gdGV4dDsKQEAg
LTE3OTgsMjcgKzE4MDIsMTAgQEAKICAgICAgICAgICAgICAgICAgICAgICAgYXByX3Bvb2xfdCAq
cmVzdWx0X3Bvb2wsCiAgICAgICAgICAgICAgICAgICAgICAgIGFwcl9wb29sX3QgKnNjcmF0Y2hf
cG9vbCkKIHsKLSAgc3ZuX3N0cmluZ2J1Zl90ICp3b3JrID0gc3ZuX3N0cmluZ2J1Zl9jcmVhdGVf
ZW5zdXJlKFNWTl9fU1RSRUFNX0NIVU5LX1NJWkUsCi0gICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICByZXN1bHRfcG9vbCk7Ci0gIGNoYXIgKmJ1ZmZl
ciA9IGFwcl9wYWxsb2Moc2NyYXRjaF9wb29sLCBTVk5fX1NUUkVBTV9DSFVOS19TSVpFKTsKKyAg
c3ZuX3N0cmluZ2J1Zl90IGJ1ZmZlcjsKKyAgU1ZOX0VSUihzdm5fc3RyaW5nYnVmX2Zyb21fc3Ry
ZWFtKCZidWZmZXIsIHN0cmVhbSwgMCwgc2NyYXRjaF9wb29sKSk7CisgICpyZXN1bHQgPSBzdm5f
c3RyaW5nX25jcmVhdGUoYnVmZmVyLmRhdGEsIGJ1ZmZlci5sZW4sIHJlc3VsdF9wb29sKTsKIAot
ICB3aGlsZSAoMSkKLSAgICB7Ci0gICAgICBhcHJfc2l6ZV90IGxlbiA9IFNWTl9fU1RSRUFNX0NI
VU5LX1NJWkU7Ci0KLSAgICAgIFNWTl9FUlIoc3ZuX3N0cmVhbV9yZWFkX2Z1bGwoc3RyZWFtLCBi
dWZmZXIsICZsZW4pKTsKLSAgICAgIHN2bl9zdHJpbmdidWZfYXBwZW5kYnl0ZXMod29yaywgYnVm
ZmVyLCBsZW4pOwotCi0gICAgICBpZiAobGVuIDwgU1ZOX19TVFJFQU1fQ0hVTktfU0laRSkKLSAg
ICAgICAgYnJlYWs7Ci0gICAgfQotCi0gIFNWTl9FUlIoc3ZuX3N0cmVhbV9jbG9zZShzdHJlYW0p
KTsKLQotICAqcmVzdWx0ID0gYXByX3BhbGxvYyhyZXN1bHRfcG9vbCwgc2l6ZW9mKCoqcmVzdWx0
KSk7Ci0gICgqcmVzdWx0KS0+ZGF0YSA9IHdvcmstPmRhdGE7Ci0gICgqcmVzdWx0KS0+bGVuID0g
d29yay0+bGVuOwotCiAgIHJldHVybiBTVk5fTk9fRVJST1I7CiB9CiAK
--001a113efc82cbc9070521834bdb--