subversion-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ivan Zhakov <i...@visualsvn.com>
Subject Re: svn commit: r1707196 - /subversion/trunk/subversion/libsvn_subr/stream.c
Date Wed, 07 Oct 2015 12:58:24 GMT
On 7 October 2015 at 15:47, Julian Foad <julianfoad@gmail.com> wrote:
> Stefan wrote:
>> I guess the correct way of doing this is revert Ivan's
>> change and apply something like the attached patch.
> Ivan wrote:
>> Here is the patch that I wanted commit later. What do you think?
>
> I am not interested in reviewing any more patches that tweak just one
> of the implementations. If you (anybody) want to do something, please
> combine the two functions into one implementation, and then I will be
> interested in reviewing the (single) implementation.
>
Merging svn_stringbuf_from_stream() and svn_stringbuf_from_stream()
implementations is completely ortogonal from my point of view.

But I really don't understand what was your point in r1707196 review
if you are not interested in review any changes to this function at
all.


-- 
Ivan Zhakov

Mime
View raw message