subversion-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Fuhrmann <stefan.fuhrm...@wandisco.com>
Subject Re: svn commit: r1707196 - /subversion/trunk/subversion/libsvn_subr/stream.c
Date Wed, 07 Oct 2015 13:04:51 GMT
On Wed, Oct 7, 2015 at 2:57 PM, Stefan Fuhrmann <
stefan.fuhrmann@wandisco.com> wrote:

> On Wed, Oct 7, 2015 at 2:47 PM, Julian Foad <julianfoad@gmail.com> wrote:
>
>> Stefan wrote:
>> > I guess the correct way of doing this is revert Ivan's
>> > change and apply something like the attached patch.
>> Ivan wrote:
>> > Here is the patch that I wanted commit later. What do you think?
>>
>> I am not interested in reviewing any more patches that tweak just one
>> of the implementations. If you (anybody) want to do something, please
>> combine the two functions into one implementation, and then I will be
>> interested in reviewing the (single) implementation.
>>
>
> Alright, here you go.
>

Ugh, pitfall: svn_string_from_stream closes the
stream after reading it. Updated patch.

-- Stefan^2.

Mime
View raw message