Return-Path: X-Original-To: apmail-subversion-dev-archive@minotaur.apache.org Delivered-To: apmail-subversion-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2DBDE17B4B for ; Tue, 8 Sep 2015 14:36:01 +0000 (UTC) Received: (qmail 95088 invoked by uid 500); 8 Sep 2015 14:35:58 -0000 Delivered-To: apmail-subversion-dev-archive@subversion.apache.org Received: (qmail 95039 invoked by uid 500); 8 Sep 2015 14:35:58 -0000 Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@subversion.apache.org Received: (qmail 95029 invoked by uid 99); 8 Sep 2015 14:35:57 -0000 Received: from Unknown (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 08 Sep 2015 14:35:57 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 5808DC6B37 for ; Tue, 8 Sep 2015 14:35:57 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.12 X-Spam-Level: X-Spam-Status: No, score=-0.12 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd1-us-west.apache.org (amavisd-new); dkim=pass (1024-bit key) header.d=visualsvn.com Received: from mx1-us-west.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 1nPzk12mgnk8 for ; Tue, 8 Sep 2015 14:35:51 +0000 (UTC) Received: from mail-ig0-f174.google.com (mail-ig0-f174.google.com [209.85.213.174]) by mx1-us-west.apache.org (ASF Mail Server at mx1-us-west.apache.org) with ESMTPS id 3ABDF2108A for ; Tue, 8 Sep 2015 14:35:51 +0000 (UTC) Received: by igbkq10 with SMTP id kq10so75373457igb.0 for ; Tue, 08 Sep 2015 07:35:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=visualsvn.com; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=2oN94kt8GfxVlSWC0IOzIrPV+4rk2CcKymK+w6VoPDU=; b=XAIMrX8AB0nfGWzyaJZkweIXr6qSs/zPTvz03XXDFWRrpujQRQbVmE+kRBaGyEpFiB 4GbXU1gd6DpFDJlIKQg46BjaEEh92wWIq26tZRGPlPgLnZ83PIFzHNvdgLWajdVRHULY U/c5vPXVKlWh8liK5CSXVdVWUJPGmpg3niD60= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=2oN94kt8GfxVlSWC0IOzIrPV+4rk2CcKymK+w6VoPDU=; b=B7MWXKl2zyMqP7AmP2s7hZjSkIbNigNnkRE4c5FlHS/8WuqEcbVdWZJJclbbTodyUt bsGoF0JxVFExjplQwCCJfXS/KwEI8QURkSTACSMgRE6hp9SDnzDtV9shqk1YmFxx2Gbh PEUTHk03poDZwB7XM8yX+fyrYbf2yEFfGnjTbjFN0kuS6dX6J6P2KLI8WEjfBUjF31zr NHARx+akfIJFqwHFUmoM2Gak7PVSg8YpSnLv/C5k8YkQqd2D0yjqYq1G62THLY7QF2MK 5wBLx9jcqejeg8cX8CTMXOtUMzCguGHGlwtWqM4kUifUROSY8jwlSI9/6g1/IF7iSSIH m4ug== X-Gm-Message-State: ALoCoQkZWb1No+mqvrZkT2KOR0Gc98fr8foRm2y/yHHWPDLca426XiORXVjeaeiCeW+laF+GPU8g X-Received: by 10.50.30.65 with SMTP id q1mr41208402igh.28.1441722950516; Tue, 08 Sep 2015 07:35:50 -0700 (PDT) MIME-Version: 1.0 Received: by 10.64.124.129 with HTTP; Tue, 8 Sep 2015 07:35:31 -0700 (PDT) In-Reply-To: References: <20150907150657.C8063AC0041@hades.apache.org> From: Evgeny Kotkov Date: Tue, 8 Sep 2015 17:35:31 +0300 Message-ID: Subject: Re: svn commit: r1701633 - /subversion/trunk/subversion/libsvn_subr/stream.c To: Ivan Zhakov Cc: Subversion Development Content-Type: text/plain; charset=UTF-8 Ivan Zhakov writes: >> Indeed, I missed that default skip_handler_apr() performs a seek that could >> be unavailable or behave surprisingly when used with a handle like STDIN. >> So, the fix is partial. >> >> What do you think about the attached patch? >> > Looks good for me. I committed this change in r1701792, r1701797 and extended the corresponding backport proposal. Regards, Evgeny Kotkov