Return-Path: X-Original-To: apmail-subversion-dev-archive@minotaur.apache.org Delivered-To: apmail-subversion-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id F035718293 for ; Thu, 24 Sep 2015 18:50:45 +0000 (UTC) Received: (qmail 3488 invoked by uid 500); 24 Sep 2015 18:50:42 -0000 Delivered-To: apmail-subversion-dev-archive@subversion.apache.org Received: (qmail 3441 invoked by uid 500); 24 Sep 2015 18:50:42 -0000 Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@subversion.apache.org Received: (qmail 3431 invoked by uid 99); 24 Sep 2015 18:50:42 -0000 Received: from Unknown (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 24 Sep 2015 18:50:42 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id E6970C12EA for ; Thu, 24 Sep 2015 18:50:41 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.1 X-Spam-Level: X-Spam-Status: No, score=-0.1 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd1-us-west.apache.org (amavisd-new); dkim=pass (1024-bit key) header.d=visualsvn.com Received: from mx1-us-west.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id YcI5p1IFXAFE for ; Thu, 24 Sep 2015 18:50:33 +0000 (UTC) Received: from mail-la0-f45.google.com (mail-la0-f45.google.com [209.85.215.45]) by mx1-us-west.apache.org (ASF Mail Server at mx1-us-west.apache.org) with ESMTPS id 2C1FD2074F for ; Thu, 24 Sep 2015 18:50:33 +0000 (UTC) Received: by lacdq2 with SMTP id dq2so18957204lac.1 for ; Thu, 24 Sep 2015 11:50:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=visualsvn.com; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=hkbeBeuY0D2ZE9D63pNBNS8UY4BHZhfg6FV9Rs3UySQ=; b=WiLCPU7v+L5il5fmX7DGblTyw3XUoswjlKuaUktwbOYoGOe2lP8WZX1zprTgj+EL7z yxEryekTcOpnGCOu5Pj5RURTsdej5rbvrWjpyzPuupW5Cg4kkPBTCaHjnRFMZeGieEad L0IIC8Kki/BdTftdfHQI+aPNS9qh6Xy00Q+iA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=hkbeBeuY0D2ZE9D63pNBNS8UY4BHZhfg6FV9Rs3UySQ=; b=UBh05iU17qdYs2X+QkU07AllGL+UYx1KwRCxKCMM8WwndApieUdRkgZO13w12wxuJK KVi0xJUpRfU+wg8Jf1FzowZyNZPw+3kB8xnWzw+Jo9js3AdOtLyCUpt+mAtUs29MdwPX EyBkMUuCgc3QLBRf5Fibs90vPU1m67UHMIBORv73lUNOsE1BmOlaUaqtQBfG+DgNdS+O L2FsOpMSOhC6S714Yw2DyL6hjhSxBgG/Gi4A4QF/iBpRDglL7LqYeaLYdR4pX9uIYvSd x9km8u3AmOZRk4C3fySnB3e+0ufw7l7kftUNszoB5ewwdSjA2v2mQxJVCQLt9UQs/mDZ HoaQ== X-Gm-Message-State: ALoCoQkeY+jcir5pRqxCjgD0zRPf7OSnALJUm7gkIKF/S9CPAYBpHofG3MB6/KmJD40FPayvL35d X-Received: by 10.152.21.74 with SMTP id t10mr341738lae.107.1443120631520; Thu, 24 Sep 2015 11:50:31 -0700 (PDT) MIME-Version: 1.0 Received: by 10.25.44.19 with HTTP; Thu, 24 Sep 2015 11:50:11 -0700 (PDT) In-Reply-To: References: <20150924135917.396E63A0234@svn01-us-west.apache.org> <002b01d0f6d6$24afce40$6e0f6ac0$@qqmail.nl> <20150924155050.GE15939@jim.stsp.name> From: Ivan Zhakov Date: Thu, 24 Sep 2015 20:50:11 +0200 Message-ID: Subject: Re: svn commit: r1705060 - in /subversion/trunk/subversion/libsvn_ra_serf: ra_serf.h serf.c util.c To: Julian Foad Cc: Bert Huijben , dev Content-Type: text/plain; charset=UTF-8 On 24 September 2015 at 19:15, Julian Foad wrote: > Ivan Zhakov wrote: >> Julian Foad wrote: >>> Ivan Zhakov wrote: >>>> [...] we also have many functions that accepts just POOL and use >>>> it as scratch pool. And we also have many functions that uses it as >>>> result pool. >>> >>> Yes, we do have many of those. That was the Old Way. Naming the pools >>> 'scratch_pool' or 'result_pool' is the New Way. We seem to generally >>> agree that is better, and sometimes we rename the single 'pool' >>> argument of old functions to either 'scratch_pool' or 'result_pool'. >> >> Could you please give me link to the thread where we discussed The New >> Way? Yes, we use result_pool/scratch_pool, but I don't remember >> discussion about never using just one POOL. > > I don't know if this was ever explicitly discussed. (The thread where > the two-pools paradigm was first publicly is: Subject "result_pool and > scratch_pool", from Greg Stein, on 2008-10-06, archived at e.g. > http://svn.haxx.se/dev/archive-2008-10/0268.shtml ) > As far I remember this thread about two pools paradigm itself (result_pool and scratch_pool). It's not about making all functions follow two pools paradigm. Some of API introduced in 1.9 doesn't follow this paradigm for some reason. Please understand me correctly: I really like two pool paradigm, but sometimes it's not necessary, especially for local helpers. -- Ivan Zhakov