Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm
Precedence: bulk
MIME-Version: 1.0
In-Reply-To: 
 <CA+t0gk2mPR=Zc83kHdFEvWPEtt=ZEY=4JUUZgOWQrmy9+QL_Kg@mail.gmail.com>
References: 
 <CA+t0gk0QV_2mwEmK-OPjoP9BzXCPPiKccW3Wg3tBwPmQcLUgcQ@mail.gmail.com>
 <87pp2tvpfc.fsf@wandisco.com>
 <CA+t0gk06ASJbrjuuNvP7CL4U1FUiT=9bybmJ=1RwMY1PTvPDGw@mail.gmail.com>
 <87oaibcx17.fsf@wandisco.com>
 <CA+t0gk2mPR=Zc83kHdFEvWPEtt=ZEY=4JUUZgOWQrmy9+QL_Kg@mail.gmail.com>
From: Julian Foad <julianfoad@btopenworld.com>
Date: Thu, 13 Aug 2015 16:44:24 +0100
Message-ID: 
 <CAEcU=1ZBsK42ptzWfZTMJs0vXLsuKVSRNgCec+qi0Uc52Wq98Q@mail.gmail.com>
Subject: Re: Review of sizeof usage
To: Stefan Fuhrmann <stefan.fuhrmann@wandisco.com>
Cc: Philip Martin <philip.martin@wandisco.com>,
	Subversion Development <dev@subversion.apache.org>
Content-Type: text/plain; charset=UTF-8

FWIW, I too have come to prefer the variable-based form, for
readability reasons. One reason is that it is easier to quickly
recognize and verify the idiom when the redundancy is in the form of
two identical names close together:

svn_my_type_t *my_var;
[...]
foo(my_var, sizeof(*my_var));  <== 'my_var' twice

than when the nearby pairing uses two different names and the
repetition of the type name is widely separated:

svn_my_type_t *my_var;
[...]
foo(my_var, sizeof(svn_my_type_t));

especially when the declaration was separate from the statement that uses it.

Another reason is that the variable name is usually shorter, the
entire statement often fitting on one line, whereas the type name is
usually a public, user-defined type (or pointer to such) with a longer
name.

- Julian