Return-Path: X-Original-To: apmail-subversion-dev-archive@minotaur.apache.org Delivered-To: apmail-subversion-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0A6DD182A8 for ; Tue, 11 Aug 2015 14:28:40 +0000 (UTC) Received: (qmail 63132 invoked by uid 500); 11 Aug 2015 14:28:27 -0000 Delivered-To: apmail-subversion-dev-archive@subversion.apache.org Received: (qmail 63078 invoked by uid 500); 11 Aug 2015 14:28:27 -0000 Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@subversion.apache.org Received: (qmail 63068 invoked by uid 99); 11 Aug 2015 14:28:26 -0000 Received: from Unknown (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 Aug 2015 14:28:26 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 46C0818193D for ; Tue, 11 Aug 2015 14:28:26 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.901 X-Spam-Level: ** X-Spam-Status: No, score=2.901 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=3, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd3-us-west.apache.org (amavisd-new); dkim=pass (1024-bit key) header.d=wandisco.com Received: from mx1-us-east.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id GWa2VfZT0mbH for ; Tue, 11 Aug 2015 14:28:17 +0000 (UTC) Received: from mail-ig0-f170.google.com (mail-ig0-f170.google.com [209.85.213.170]) by mx1-us-east.apache.org (ASF Mail Server at mx1-us-east.apache.org) with ESMTPS id 9B96342B42 for ; Tue, 11 Aug 2015 14:28:17 +0000 (UTC) Received: by igfj19 with SMTP id j19so73032699igf.1 for ; Tue, 11 Aug 2015 07:28:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wandisco.com; s=gapps; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=P6ZnJxBMVrfwFQrEB3a9UI42Vp8+LawCLs8ss2OnPOE=; b=bbLO7hSCX7AspZuZpS7pKMXQADZwojm+xjvXIx6Me2+uS3LU3ZSJXLKHUaEFp7/Cpe 2873u/7MRthceNiZ3fWyMk2vITs2FXV0DstLPrWDZGBAiLzZPWG2sgdVM0RoUqay7xRQ 5zZV6NaK2SQ1FHB5eMyV6FDgMxfqVSIi7e950= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=P6ZnJxBMVrfwFQrEB3a9UI42Vp8+LawCLs8ss2OnPOE=; b=kghTCwCXQ/93xPBIy0cTyag+IoACCgNp2J64VDkCULXhVoqo13vymveDTs5ftBTtpX pO9g9SrPDTXSQ1O1122nYAz2tGqOkFVtY0rrLJp4dRff67PVzEG06fY4f9LziyVFdjBt grbx1r8LHoRCZCqFhaCwkgbk2MULDIeYpeCQwZ15TdaOVrC8qjafS/B+4pjxHkWDntxr BNtj271DwoSW+lnJvSBG/hv66J/yJOyugoZ/PyUsg99bvYNigTz4UQb1XmPlt4LbIVTA usVbNs4WRIbsxRBBZP6G8Gy+H9QRAvqzUnTL22LcSTFApAItWnPrjyS4LvVwhqmMTnIa A6uQ== X-Gm-Message-State: ALoCoQkVpFXQ/WvtLU36qpb4jp+H/PHg5t042tbPL32TqweLpEDOE5kAQtYNbCJ+JxZZtJiZsf6t MIME-Version: 1.0 X-Received: by 10.50.30.196 with SMTP id u4mr18802779igh.11.1439303297214; Tue, 11 Aug 2015 07:28:17 -0700 (PDT) Received: by 10.50.250.172 with HTTP; Tue, 11 Aug 2015 07:28:17 -0700 (PDT) In-Reply-To: References: <20150806125437.3C4A4AC0335@hades.apache.org> Date: Tue, 11 Aug 2015 15:28:17 +0100 Message-ID: Subject: Re: svn commit: r1694489 [1/2] - in /subversion/trunk: ./ subversion/include/private/ subversion/libsvn_fs_fs/ subversion/libsvn_fs_x/ subversion/libsvn_subr/ subversion/tests/libsvn_subr/ From: Stefan Fuhrmann To: Ivan Zhakov Cc: Subversion Development , Stefan Fuhrman Content-Type: multipart/alternative; boundary=047d7bdc11bcc15000051d09e922 --047d7bdc11bcc15000051d09e922 Content-Type: text/plain; charset=UTF-8 On Fri, Aug 7, 2015 at 2:57 PM, Stefan Fuhrmann < stefan.fuhrmann@wandisco.com> wrote: > On Thu, Aug 6, 2015 at 3:59 PM, Ivan Zhakov wrote: > >> On 6 August 2015 at 15:54, wrote: >> > Author: stefan2 >> > Date: Thu Aug 6 12:54:36 2015 >> > New Revision: 1694489 >> > >> > URL: http://svn.apache.org/r1694489 >> > Log: >> > Merge the 1.10-cache-improvements development branch to trunk and remove >> > the BRANCH-README file. There were no conflicts. >> > >> > Changes brought by this branch: >> > - Introduce a NULL cache implementation to unify / simplify cache usage >> > - Space and runtime efficiency improvements to the recently introduced >> > full key comparison in membuffer caches. > > > Also after this change fs-test.exe fails with assertion in Windows >> 32-bit Debug build: >> [[ >> START: fs-test.exe >> Assertion failed: !group || !group->header.used, file >> ..\..\..\subversion\libsvn_subr\cache-membuffer.c, line 1031 >> ]] >> > > This one is odd because the merge did not touch anything > obviously linked to spare bucket handling. Could be a long- > standing issue. > > I failed to reproduce it with a 32 bit debug build on Win64. > Does it fail for you in serial execution mode? Is it deterministic > in that case? Does the attached patch prevent it? > Tweaking the code a bit I was finally able to reproduce the problem. It has been introduced in 1.9 and is fixed by r1695022. The merge above only triggered it by enlarging the cache index structure, in turn reducing the capacity of individual entry groups - making them more likely to overflow and trigger the allocation of spare groups. -- Stefan^2. --047d7bdc11bcc15000051d09e922 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


On Fri, Aug 7, 2015 at 2:57 PM, Stefan Fuhrmann <<= a href=3D"mailto:stefan.fuhrmann@wandisco.com" target=3D"_blank">stefan.fuh= rmann@wandisco.com> wrote:
=
On Thu, Aug 6, 2015 at 3:59 PM, Ivan Zhakov = <ivan@visualsvn.= com> wrote:
On 6 August 201= 5 at 15:54,=C2=A0 <stefan2@apache.org> wrote:
> Author: stefan2
> Date: Thu Aug=C2=A0 6 12:54:36 2015
> New Revision: 1694489
>
> URL: http://svn.apache.org/r1694489
> Log:
> Merge the 1.10-cache-improvements development branch to trunk and remo= ve
> the BRANCH-README file.=C2=A0 There were no conflicts.
>
> Changes brought by this branch:
> - Introduce a NULL cache implementation to unify / simplify cache usag= e
> - Space and runtime efficiency improvements to the recently introduced=
>=C2=A0 =C2=A0full key comparison in membuffer caches.

Also after this change fs-test.exe fails with assertion in Windows
32-bit Debug build:
[[
START: fs-test.exe
Assertion failed: !group || !group->header.used, file
..\..\..\subversion\libsvn_subr\cache-membuffer.c, line 1031
]]

This one is odd because the m= erge did not touch anything
obviously linked to spare bucket handling. C= ould be a long-
standing issue.

I failed to reproduce it with a 3= 2 bit debug build on Win64.
Does it fail for you in serial ex= ecution mode? Is it deterministic
in that case? Does the atta= ched patch prevent it?

Tw= eaking the code a bit I was finally able to reproduce the problem.
It has been introduced in 1.9 and is fixed by r= 1695022.

The merge above only trigg= ered it by enlarging the cache index
st= ructure, in turn reducing the capacity of individual entry groups -
making them more likely to overflow and trigge= r the allocation of
spare groups.
-- Stefan^2.

--047d7bdc11bcc15000051d09e922--