Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm
Precedence: bulk
MIME-Version: 1.0
In-Reply-To: <55C33F1E.4030406@dreweke.net>
References: <55C33F1E.4030406@dreweke.net>
Date: Thu, 6 Aug 2015 13:33:02 +0100
Message-ID: 
 <CA+t0gk1KUutNwOd1p=y+8A2v7PWSXgJcx64nnF00UWW+2pnGGg@mail.gmail.com>
Subject: Re: Can't build subversion 1.9 or master without gpg-agent
From: Stefan Fuhrmann <stefan.fuhrmann@wandisco.com>
To: Alexander Dreweke <alexander@dreweke.net>
Cc: Subversion Development <dev@subversion.apache.org>
Content-Type: multipart/alternative; boundary=001a11406ee66ad894051ca3b8f2

--001a11406ee66ad894051ca3b8f2
Content-Type: text/plain; charset=UTF-8

On Thu, Aug 6, 2015 at 12:03 PM, Alexander Dreweke <alexander@dreweke.net>
wrote:

> Hi
>
> when trying to build subversion without gpg-agent support the build fails.
>
> All code in subversion/libsvn_subr/gpg_agent.c is encapsulated in #ifdef
> SVN_HAVE_GPG_AGENT, but the call to svn_auth__get_gpg_agent_simple_provider
> in subversion/libsvn_subr/deprecated.c is missing this check.
>
> With this patch I'm able to compile subversion without errors.
>
> cu
>     Alex
>

Hi Alex,

Thank you for the patch!
Committed as r1694481 and proposed for backport into 1.9.x.

-- Stefan^2.

--001a11406ee66ad894051ca3b8f2
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_extra"><div class=3D"gmail_quote">On T=
hu, Aug 6, 2015 at 12:03 PM, Alexander Dreweke <span dir=3D"ltr">&lt;<a hre=
f=3D"mailto:alexander@dreweke.net" target=3D"_blank">alexander@dreweke.net<=
/a>&gt;</span> wrote:<br><blockquote class=3D"gmail_quote" style=3D"margin:=
0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi<br>
<br>
when trying to build subversion without gpg-agent support the build fails.<=
br>
<br>
All code in subversion/libsvn_subr/gpg_agent.c is encapsulated in #ifdef SV=
N_HAVE_GPG_AGENT, but the call to svn_auth__get_gpg_agent_simple_provider i=
n subversion/libsvn_subr/deprecated.c is missing this check.<br>
<br>
With this patch I&#39;m able to compile subversion without errors.<br>
<br>
cu<br>
=C2=A0 =C2=A0 Alex<br></blockquote><div><br></div><div>Hi Alex,<br><br></di=
v><div>Thank you for the patch!<br></div><div>Committed as r1694481 and pro=
posed for backport into 1.9.x.<br><br></div><div>-- Stefan^2. <br></div></d=
iv><br></div></div>

--001a11406ee66ad894051ca3b8f2--