Return-Path: X-Original-To: apmail-subversion-dev-archive@minotaur.apache.org Delivered-To: apmail-subversion-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0BFF510E75 for ; Wed, 26 Aug 2015 17:01:21 +0000 (UTC) Received: (qmail 23675 invoked by uid 500); 26 Aug 2015 17:01:20 -0000 Delivered-To: apmail-subversion-dev-archive@subversion.apache.org Received: (qmail 23625 invoked by uid 500); 26 Aug 2015 17:01:20 -0000 Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@subversion.apache.org Received: (qmail 23615 invoked by uid 99); 26 Aug 2015 17:01:20 -0000 Received: from Unknown (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 26 Aug 2015 17:01:20 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 21AB5EE45D for ; Wed, 26 Aug 2015 17:01:20 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.9 X-Spam-Level: ** X-Spam-Status: No, score=2.9 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=3, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd1-us-west.apache.org (amavisd-new); dkim=pass (1024-bit key) header.d=wandisco.com Received: from mx1-us-east.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id M6CGxO45e-MG for ; Wed, 26 Aug 2015 17:01:13 +0000 (UTC) Received: from mail-ig0-f178.google.com (mail-ig0-f178.google.com [209.85.213.178]) by mx1-us-east.apache.org (ASF Mail Server at mx1-us-east.apache.org) with ESMTPS id 95D0942F2E for ; Wed, 26 Aug 2015 17:01:13 +0000 (UTC) Received: by igfj19 with SMTP id j19so16862951igf.1 for ; Wed, 26 Aug 2015 10:01:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wandisco.com; s=gapps; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=soogLuffx4rJCgYcAV8wTLY5Cfh+mvHHjgS0jBvIazE=; b=eMFuSNbmjZfNIwRSuwXvUNTmlTf6Nd+Z8g7vWK5XrVS59Zj1NRzvda4fwKAdBjnxV+ arYAmW+e9Lk+7FZ7nldBTgj9r0U76+iKpMY+LNc3MsFuNoyozylCLU1ifbGKPLbLJpaP lhhPqiYKIp5+FJW7eudvWBxydtz0hvY55V3r4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=soogLuffx4rJCgYcAV8wTLY5Cfh+mvHHjgS0jBvIazE=; b=EABU2zs0a1JcLd1ByTb1fK+Jr9YQDqRHA1+s/1G4srTsgVx5HXJDl8KinBVQ3VPziP kEHyqO39sZw4TnxHj/3pO1QZO6o4kxa9MfC5m63zDnQyqSuMIaTuu9N6KLKyNhAqhtuw wLhSckE6iJV0oWWev66Nej8fa7pewPYU3JiMQW5pak5Mmp6WuDHFSMaPyrnWoenX75d2 aR+j5qFwp7dFIjHFOQABDYs47/U0jBoiR19I4sA6X+FKgWmYZ2HNzYY5NkAGNgrC90kN Qx6ZSEvp9i5sQ69Bq4q6wzvcSr0rhTn7k2WTqGb4KNMJrFrnoPiMSBqCcR9n7YfrBONI K4YA== X-Gm-Message-State: ALoCoQlIINF3ls6RM2opj4BHfQ+5Aj92282G0UDeTf+z1Vg8zhCkhQiCXrOEScDsjUfj4bh1hHIt MIME-Version: 1.0 X-Received: by 10.50.30.226 with SMTP id v2mr12777203igh.11.1440608473113; Wed, 26 Aug 2015 10:01:13 -0700 (PDT) Received: by 10.50.159.132 with HTTP; Wed, 26 Aug 2015 10:01:12 -0700 (PDT) In-Reply-To: <55DC7E8C.7080008@wandisco.com> References: <20150824133241.B2AD8AC058C@hades.apache.org> <55DC7E8C.7080008@wandisco.com> Date: Wed, 26 Aug 2015 18:01:12 +0100 Message-ID: Subject: Re: svn commit: r1697390 - /subversion/branches/1.9.x/STATUS From: Stefan Fuhrmann To: =?UTF-8?Q?Branko_=C4=8Cibej?= Cc: Subversion Development Content-Type: multipart/alternative; boundary=047d7b86d5024d0219051e39ccc8 --047d7b86d5024d0219051e39ccc8 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Tue, Aug 25, 2015 at 3:41 PM, Branko =C4=8Cibej wro= te: > On 24.08.2015 15:32, stefan2@apache.org wrote: > > Author: stefan2 > > Date: Mon Aug 24 13:32:41 2015 > > New Revision: 1697390 > > > > URL: http://svn.apache.org/r1697390 > > Log: > > * STATUS: Add svnfsfs load-index fixes (r1697381, r1697384, r1697387). > > > > Modified: > > subversion/branches/1.9.x/STATUS > > > > Modified: subversion/branches/1.9.x/STATUS > > URL: > http://svn.apache.org/viewvc/subversion/branches/1.9.x/STATUS?rev=3D16973= 90&r1=3D1697389&r2=3D1697390&view=3Ddiff > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > > --- subversion/branches/1.9.x/STATUS (original) > > +++ subversion/branches/1.9.x/STATUS Mon Aug 24 13:32:41 2015 > > @@ -129,6 +129,15 @@ Candidate changes: > > Votes: > > +1: rhuijben > > > > + * r1697381, r1697384, r1697387 > > + Make 'svnfsfs load-index' work as advertised in the documentation > > + Justification: > > + svnfsfs load-index would only ever be used in high-stress > situations > > + like desaster recovery. So, while workarounds are possible, havi= ng > > + people jump though a few extra hoops is a bad thing in that > context. > > + Votes: > > + +1: stefan2 > > + > > I have to admit that I don't have a clue what this backport proposal is > about. What doesn't work as advertised? What kind of workarounds are we > talking about? > I documented them today in our release notes (r1697932). > According to the log messages of these three revisions, it would appear > that they're three (unrelated?) bug fixes in svnfsfs. However, I can't > find any test cases that would help me verify that the fixes actually > perform as advertised. > All 3 patches correct / deal with 'svnfsfs load-index' UI issues where the tool would feed wrong data to FSFS' private APIs. The actual internal API functionality is covered by fs-fs-private-tests. r1697967 adds a UI test. I appended it to the list. > In other words, I've no idea how to vote for this backport. > In case you want more input, clarification etc, I should be on IRC from around 0930 UTC on tomorrow. -- Stefan^2. --047d7b86d5024d0219051e39ccc8 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


On Tue, Aug 25, 2015 at 3:41 PM, Branko =C4=8Cibej &l= t;brane@wandisco.co= m> wrote:
24.08.2015 15:32, stefan2@apache.org wrote:<= br> > Author: stefan2
> Date: Mon Aug 24 13:32:41 2015
> New Revision: 1697390
>
> URL: http://svn.apache.org/r1697390
> Log:
> * STATUS: Add svnfsfs load-index fixes (r1697381, r1697384, r1697387).=
>
> Modified:
>=C2=A0 =C2=A0 =C2=A0subversion/branches/1.9.x/STATUS
>
> Modified: subversion/branches/1.9.x/STATUS
> URL: http://svn.apache.org/viewvc/subversion/= branches/1.9.x/STATUS?rev=3D1697390&r1=3D1697389&r2=3D1697390&v= iew=3Ddiff
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D
> --- subversion/branches/1.9.x/STATUS (original)
> +++ subversion/branches/1.9.x/STATUS Mon Aug 24 13:32:41 2015
> @@ -129,6 +129,15 @@ Candidate changes:
>=C2=A0 =C2=A0 =C2=A0Votes:
>=C2=A0 =C2=A0 =C2=A0 =C2=A0+1: rhuijben
>
> + * r1697381, r1697384, r1697387
> +=C2=A0 =C2=A0Make 'svnfsfs load-index' work as advertised in = the documentation
> +=C2=A0 =C2=A0Justification:
> +=C2=A0 =C2=A0 =C2=A0svnfsfs load-index would only ever be used in hig= h-stress situations
> +=C2=A0 =C2=A0 =C2=A0like desaster recovery.=C2=A0 So, while workaroun= ds are possible, having
> +=C2=A0 =C2=A0 =C2=A0people jump though a few extra hoops is a bad thi= ng in that context.
> +=C2=A0 =C2=A0Votes:
> +=C2=A0 =C2=A0 =C2=A0+1: stefan2
> +

I have to admit that I don't have a clue what this backport proposal is=
about. What doesn't work as advertised? What kind of workarounds are we=
talking about?

I documented them today = in our release notes (r1697932).
=C2=A0
According to the log messages of these three revisions, it would appear
that they're three (unrelated?) bug fixes in svnfsfs. However, I can= 9;t
find any test cases that would help me verify that the fixes actually
perform as advertised.

All 3 patch= es correct / deal with 'svnfsfs load-index' UI issues
where the tool would feed wrong data to FSFS' private APIs.
<= div>The actual internal API functionality is covered by fs-fs-private-tests= .

r1697967 adds a UI test. I appended it to the lis= t.
=C2=A0
In other words, I've no idea how to vote for this backport.

In case you want more input, clarification etc, I should be<= br>on IRC from around 0930 UTC on tomorrow.

-- Stefan^2.
--047d7b86d5024d0219051e39ccc8--