Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm
Precedence: bulk
Subject: Re: svn commit: r1697654 - /subversion/branches/1.9.x/STATUS
To: dev@subversion.apache.org
References: <20150825114910.3BE91AC05CA@hades.apache.org>
 <55DC57B3.5050009@wandisco.com>
 <CA+t0gk06CirGTDDt+_jHe+dWU-PHt0nzu0DMmX4Z6j2zQSwLCw@mail.gmail.com>
 <55DC8D0A.3010606@wandisco.com>
 <CA+t0gk2mTCi2=iihj-W0HdeppG8Y2R+U9dw6+VT=RQvY-C+BUA@mail.gmail.com>
 <55DD4E17.2050102@wandisco.com> <20150826053458.GC19027@tarsus.local2>
From: =?UTF-8?Q?Branko_=c4=8cibej?= <brane@wandisco.com>
Organization: WANdisco
Message-ID: <55DD6A19.9040809@wandisco.com>
Date: Wed, 26 Aug 2015 09:26:17 +0200
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:38.0)
 Gecko/20100101 Thunderbird/38.2.0
MIME-Version: 1.0
In-Reply-To: <20150826053458.GC19027@tarsus.local2>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit

On 26.08.2015 07:34, Daniel Shahaf wrote:
> Branko Čibej wrote on Wed, Aug 26, 2015 at 07:26:47 +0200:
>> On 25.08.2015 23:12, Stefan Fuhrmann wrote:
>>> On Tue, Aug 25, 2015 at 4:43 PM, Branko Čibej <brane@wandisco.com> wrote:
>>>> Daniel suggested inserting a dummy handler if we don't have the GPG
>>>> agent support. I think that may be the only reasonable solution for both
>>>> trunk and 1.9.1 (or .x if we don't thing it's important enough for .1).
>>>>
>>>> The real effort here is double-checking that a dummy handler won't break
>>>> credentials resolution.
>>>>
>>> I think just starting with a full copying the GPG agent handler and
>>> making each call return "failed" should work. Didn't try it, though.
>> I'll give this a go and hopefully come up with a test case, too.
> I think you might be able to get away with:
>
>     static svn_auth_provider_t dummy = {
>         .cred_kind = "dummy", NULL, NULL, NULL
>     };

I just added a private function to return a dummy simple provider; see
r1697824.

-- Brane