subversion-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Branko Čibej <br...@wandisco.com>
Subject Re: svn commit: r1697654 - /subversion/branches/1.9.x/STATUS
Date Wed, 26 Aug 2015 07:26:17 GMT
On 26.08.2015 07:34, Daniel Shahaf wrote:
> Branko Čibej wrote on Wed, Aug 26, 2015 at 07:26:47 +0200:
>> On 25.08.2015 23:12, Stefan Fuhrmann wrote:
>>> On Tue, Aug 25, 2015 at 4:43 PM, Branko Čibej <brane@wandisco.com> wrote:
>>>> Daniel suggested inserting a dummy handler if we don't have the GPG
>>>> agent support. I think that may be the only reasonable solution for both
>>>> trunk and 1.9.1 (or .x if we don't thing it's important enough for .1).
>>>>
>>>> The real effort here is double-checking that a dummy handler won't break
>>>> credentials resolution.
>>>>
>>> I think just starting with a full copying the GPG agent handler and
>>> making each call return "failed" should work. Didn't try it, though.
>> I'll give this a go and hopefully come up with a test case, too.
> I think you might be able to get away with:
>
>     static svn_auth_provider_t dummy = {
>         .cred_kind = "dummy", NULL, NULL, NULL
>     };

I just added a private function to return a dummy simple provider; see
r1697824.

-- Brane

Mime
View raw message