subversion-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan <luke1...@posteo.de>
Subject Re: [PATCH] correct ToolsVersion in VS project files
Date Mon, 10 Aug 2015 02:35:26 GMT
On 10/08/2015 04:01, Stefan wrote:
> Hi,
>
> attached are patches for SVN 1.7, 1.8, 1.9 and trunk which correct the 
> ToolsVersion-setting in the generated project/filter files for VS >= 
> 2010.
> As of VS 2013 the ToolsVersion is no longer statically set to 4.0, but 
> rather to the correct toolset version (see: 
> https://msdn.microsoft.com/en-us/library/bb383796.aspx).
>
> While I'm not aware of any concrete issue here, for the sake of 
> correctness I believe this to be a patch which is worth applying to 
> 1.7+ (so that the in 1.7.21 mentioned VS 2015 is "as correct as 
> possible").
>
> The patch for 1.7 also drops a redundant entry from gen_win.py (the 
> VS2010 entry was specified twice there).
>
> 1.7:
> [[
> Sets the ToolsVersion value correctly in the VS project files for VS 
> >= 2013.
> Also drops a redundant entry for VS2010.
>
> * build/generator/gen_vcnet_vcproj.py:
>    (write_project): add data.tools_version
>
> * build/generator/gen_win.py:
>    (parse_options): remove redundant VS 2010 section and specify 
> values for
>                     tools_version
>    (move_proj_file): copy tools_version to data
>
> * build/generator/templates/neon.vcxproj.ezt
> * build/generator/templates/serf.vcxproj.ezt
> * build/generator/templates/svn_config.vcxproj.ezt
> * build/generator/templates/svn_locale.vcxproj.ezt
> * build/generator/templates/vcnet_vcxproj.ezt
> * build/generator/templates/vcnet_vcxproj_filters.ezt
> * build/generator/templates/zlib.vcxproj.ezt
>    (): set ToolsVersion to VS version specific value
> ]]
>
> 1.8:
> [[
> Sets the ToolsVersion value correctly in the VS project files for VS 
> >= 2013.
>
> * build/generator/gen_vcnet_vcproj.py:
>    (write_project): add data.tools_version
>
> * build/generator/gen_win.py:
>    (parse_options): specify values for tools_version
>    (move_proj_file): copy tools_version to data
>
> * build/generator/templates/serf.vcxproj.ezt
> * build/generator/templates/svn_config.vcxproj.ezt
> * build/generator/templates/svn_locale.vcxproj.ezt
> * build/generator/templates/vcnet_vcxproj.ezt
> * build/generator/templates/vcnet_vcxproj_filters.ezt
> * build/generator/templates/zlib.vcxproj.ezt
>    (): set ToolsVersion to VS version specific value
> ]]
>
> 1.9+trunk:
> [[
> Sets the ToolsVersion value correctly in the VS project files for VS 
> >= 2013.
>
> * build/generator/gen_vcnet_vcproj.py:
>    (write_project): add data.tools_version
>
> * build/generator/gen_win.py:
>    (move_proj_file): copy tools_version to data
>
> * build/generator/gen_win_dependencies.py:
>    (parse_options): specify values for tools_version
>
> * build/generator/templates/svn_config.vcxproj.ezt
> * build/generator/templates/svn_locale.vcxproj.ezt
> * build/generator/templates/vcnet_vcxproj.ezt
> * build/generator/templates/vcnet_vcxproj_filters.ezt
>    (): set ToolsVersion to VS version specific value
> ]]
>
> Regards,
> Stefan
Attached is a corrected patch for trunk (last one contained an 
unintentional change in INSTALL).

Regards,
Stefan

Mime
View raw message