subversion-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Brett Randall <javabr...@gmail.com>
Subject [PATCH 2/2] Review feedback, added check for unexpected EOF in svnlook proplist when reading-ahead in new format.
Date Mon, 24 Aug 2015 00:42:30 GMT
Signed-off-by: Brett Randall <javabrett@gmail.com>
---
 contrib/hook-scripts/check-mime-type.pl | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/contrib/hook-scripts/check-mime-type.pl b/contrib/hook-scripts/check-mime-type.pl
index 8789aaa..3ded119 100755
--- a/contrib/hook-scripts/check-mime-type.pl
+++ b/contrib/hook-scripts/check-mime-type.pl
@@ -133,6 +133,10 @@ foreach my $path ( @files_added )
 						# from propname : propvalue format, to values in an indent list on following lines
 						if (not $mime_type)
 							{
+								if ($output_line + 1 >= scalar(@output))
+									{
+										die "$0: Unexpected EOF reading proplist.\n";
+									}
 								my $next_line_pval_indented = $output[$output_line + 1];
 								if ($next_line_pval_indented =~ /^\s{4}(.*)/)
 									{
@@ -145,6 +149,10 @@ foreach my $path ( @files_added )
 						$eol_style = $2;
 						if (not $eol_style)
 							{
+								if ($output_line + 1 >= scalar(@output))
+									{
+										die "$0: Unexpected EOF reading proplist.\n";
+									}
 								my $next_line_pval_indented = $output[$output_line + 1];
 								if ($next_line_pval_indented =~ /^\s{4}(.*)/)
 									{
-- 
2.5.0


Mime
View raw message