Return-Path: X-Original-To: apmail-subversion-dev-archive@minotaur.apache.org Delivered-To: apmail-subversion-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7C0BC18578 for ; Mon, 20 Jul 2015 16:38:43 +0000 (UTC) Received: (qmail 93941 invoked by uid 500); 20 Jul 2015 16:38:35 -0000 Delivered-To: apmail-subversion-dev-archive@subversion.apache.org Received: (qmail 93888 invoked by uid 500); 20 Jul 2015 16:38:35 -0000 Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@subversion.apache.org Received: (qmail 93878 invoked by uid 99); 20 Jul 2015 16:38:35 -0000 Received: from Unknown (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 20 Jul 2015 16:38:35 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 9BF431A74A7 for ; Mon, 20 Jul 2015 16:38:34 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 4.001 X-Spam-Level: **** X-Spam-Status: No, score=4.001 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=3, KAM_LAZY_DOMAIN_SECURITY=1, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-eu-west.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id ifUCghUZj-Ck for ; Mon, 20 Jul 2015 16:38:27 +0000 (UTC) Received: from deepth.de (deepth.de [81.169.159.190]) by mx1-eu-west.apache.org (ASF Mail Server at mx1-eu-west.apache.org) with ESMTPS id A937520C4B for ; Mon, 20 Jul 2015 16:38:26 +0000 (UTC) Received: from b2b-130-180-18-42.unitymedia.biz ([130.180.18.42] helo=[192.168.3.120]) by deepth.de with esmtpa (Exim 4.72) (envelope-from ) id 1ZHE4r-0000W8-0m; Mon, 20 Jul 2015 18:38:05 +0200 Subject: Re: crash in svn-mergeinfo-normalizer To: Stefan Fuhrmann References: <55A63009.7020100@egosoft.com> Cc: "dev@subversion.apache.org" From: Stefan Hett Message-ID: <55AD23EC.1050303@egosoft.com> Date: Mon, 20 Jul 2015 18:38:04 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/alternative; boundary="------------060903010207000303040202" This is a multi-part message in MIME format. --------------060903010207000303040202 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit > On Wed, Jul 15, 2015 at 12:03 PM, Stefan Hett > wrote: > > Hi Stefan^2, > > I've just tried to rerun the latest svn-mergeinfo-normalizer. > > Running the command "svn-mergeinfo-normalizer normalize" the > application crashes in local_lookup() in missing-branches.c in > line 95 due to lookup being null: > if (apr_hash_get(lookup->existing, branch, len)) > > let me know if u need any further details (crash log file and > dump/pdb/exe available). > Callstack: > svn-mergeinfo-normalizer.exe!local_lookup(const > svn_min__branch_lookup_t * lookup, const char * branch) Line 95 + > 0xc bytes C > svn-mergeinfo-normalizer.exe!remove_lines(svn_min__log_t * log, > svn_min__branch_lookup_t * lookup, const char * relpath, > apr_hash_t * parent_mergeinfo, apr_hash_t * subtree_mergeinfo, > svn_min__opt_state_t * opt_state, apr_pool_t * scratch_pool) Line > 307 + 0xe bytes C > svn-mergeinfo-normalizer.exe!normalize(apr_array_header_t * > wc_mergeinfo, svn_min__log_t * log, svn_min__branch_lookup_t * > lookup, svn_min__opt_state_t * opt_state, apr_pool_t * > scratch_pool) Line 677 + 0x18 bytes C > svn-mergeinfo-normalizer.exe!svn_min__normalize(apr_getopt_t * > os, void * baton, apr_pool_t * pool) Line 49 + 0x337 bytes C > libsvn_subr-1.dll!svn_opt_push_implicit_dot_target(apr_array_header_t > * targets, apr_pool_t * pool) Line 703 + 0x7 bytes C > > > Hi Stefan, > > Thanks for the report! Whenever you didn't specify > '--remove-obsoletes', it application would likely crash. > Fixed in r1691520. > > -- Stefan^2. Hi Stefan^2, I just confirmed the latest code fixes the crash. Thanks for the quick help. Regards, Stefan --------------060903010207000303040202 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 8bit
On Wed, Jul 15, 2015 at 12:03 PM, Stefan Hett <stefan@egosoft.com> wrote:
Hi Stefan^2,

I've just tried to rerun the latest svn-mergeinfo-normalizer.

Running the command "svn-mergeinfo-normalizer normalize" the application crashes in local_lookup() in missing-branches.c in line 95 due to lookup being null:
if (apr_hash_get(lookup->existing, branch, len))

let me know if u need any further details (crash log file and dump/pdb/exe available).
Callstack:
     svn-mergeinfo-normalizer.exe!local_lookup(const svn_min__branch_lookup_t * lookup, const char * branch)  Line 95 + 0xc bytes    C
     svn-mergeinfo-normalizer.exe!remove_lines(svn_min__log_t * log, svn_min__branch_lookup_t * lookup, const char * relpath, apr_hash_t * parent_mergeinfo, apr_hash_t * subtree_mergeinfo, svn_min__opt_state_t * opt_state, apr_pool_t * scratch_pool)  Line 307 + 0xe bytes    C
     svn-mergeinfo-normalizer.exe!normalize(apr_array_header_t * wc_mergeinfo, svn_min__log_t * log, svn_min__branch_lookup_t * lookup, svn_min__opt_state_t * opt_state, apr_pool_t * scratch_pool)  Line 677 + 0x18 bytes    C
     svn-mergeinfo-normalizer.exe!svn_min__normalize(apr_getopt_t * os, void * baton, apr_pool_t * pool)  Line 49 + 0x337 bytes    C
libsvn_subr-1.dll!svn_opt_push_implicit_dot_target(apr_array_header_t * targets, apr_pool_t * pool)  Line 703 + 0x7 bytes    C

Hi Stefan,

Thanks for the report! Whenever you didn't specify
'--remove-obsoletes', it application would likely crash.
Fixed in r1691520.

-- Stefan^2.
Hi Stefan^2,

I just confirmed the latest code fixes the crash. Thanks for the quick help.

Regards,
Stefan
--------------060903010207000303040202--