Return-Path: X-Original-To: apmail-subversion-dev-archive@minotaur.apache.org Delivered-To: apmail-subversion-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 69544187CD for ; Fri, 8 May 2015 09:52:49 +0000 (UTC) Received: (qmail 19346 invoked by uid 500); 8 May 2015 09:52:48 -0000 Delivered-To: apmail-subversion-dev-archive@subversion.apache.org Received: (qmail 19288 invoked by uid 500); 8 May 2015 09:52:48 -0000 Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@subversion.apache.org Received: (qmail 19278 invoked by uid 99); 8 May 2015 09:52:48 -0000 Received: from Unknown (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 08 May 2015 09:52:48 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 2AF1E1A2428 for ; Fri, 8 May 2015 09:52:48 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.219 X-Spam-Level: X-Spam-Status: No, score=0.219 tagged_above=-999 required=6.31 tests=[FREEMAIL_ENVFROM_END_DIGIT=0.25, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-us-west.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 0mAjycQrOXKb for ; Fri, 8 May 2015 09:52:47 +0000 (UTC) Received: from DUB004-OMC3S26.hotmail.com (dub004-omc3s26.hotmail.com [157.55.2.35]) by mx1-us-west.apache.org (ASF Mail Server at mx1-us-west.apache.org) with ESMTPS id 16B012123F for ; Fri, 8 May 2015 09:52:46 +0000 (UTC) Received: from DUB128-W93 ([157.55.2.9]) by DUB004-OMC3S26.hotmail.com over TLS secured channel with Microsoft SMTPSVC(7.5.7601.22751); Fri, 8 May 2015 02:52:39 -0700 X-TMN: [hxFdUxoXypasMdtM1ZD9B6EVfCxUr8S4] X-Originating-Email: [dcb314@hotmail.com] Message-ID: From: David Binderman To: "dev@subversion.apache.org" Subject: JNIUtil.cpp:583: dangling pointer ? Date: Fri, 8 May 2015 09:52:38 +0000 Importance: Normal In-Reply-To: <873837foz6.fsf@wandisco.com> References: ,<873837foz6.fsf@wandisco.com> Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginalArrivalTime: 08 May 2015 09:52:39.0132 (UTC) FILETIME=[B814B1C0:01D08974] Hello there=2C=0A= =0A= [subversion-1.9.0-beta1/subversion/bindings/javahl/native/JNIUtil.cpp:583]:= (error) Dangerous usage of c_str(). The value returned by c_str() is inval= id after this call.=0A= =0A= =0A= #ifdef SVN_DEBUG=0A= #ifndef SVN_ERR__TRACING=0A= =A0 if (err->file)=0A= =A0=A0=A0 {=0A= =A0=A0=A0=A0=A0 std::ostringstream buf=3B=0A= =A0=A0=A0=A0=A0 buf << err->file=3B=0A= =A0=A0=A0=A0=A0 if (err->line> 0)=0A= =A0=A0=A0=A0=A0=A0=A0 buf << ':' << err->line=3B=0A= =A0=A0=A0=A0=A0 source =3D buf.str().c_str()=3B=0A= =A0=A0=A0 }=0A= #endif=0A= #endif=0A= =0A= Luckily=2C it's only debug code=2C but you might want to fix it anyway.=0A= =0A= Regards=0A= =0A= David Binderman=0A= =0A= =