Return-Path: X-Original-To: apmail-subversion-dev-archive@minotaur.apache.org Delivered-To: apmail-subversion-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E9A6C18C3B for ; Wed, 20 May 2015 07:57:28 +0000 (UTC) Received: (qmail 59724 invoked by uid 500); 20 May 2015 07:57:28 -0000 Delivered-To: apmail-subversion-dev-archive@subversion.apache.org Received: (qmail 59675 invoked by uid 500); 20 May 2015 07:57:28 -0000 Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@subversion.apache.org Received: (qmail 59654 invoked by uid 99); 20 May 2015 07:57:28 -0000 Received: from Unknown (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 20 May 2015 07:57:28 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id E8A7CC6BE8 for ; Wed, 20 May 2015 07:57:27 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.9 X-Spam-Level: ** X-Spam-Status: No, score=2.9 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=3, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd1-us-west.apache.org (amavisd-new); dkim=pass (1024-bit key) header.d=wandisco.com Received: from mx1-us-west.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id rs9DwInvRLFX for ; Wed, 20 May 2015 07:57:19 +0000 (UTC) Received: from mail-ig0-f178.google.com (mail-ig0-f178.google.com [209.85.213.178]) by mx1-us-west.apache.org (ASF Mail Server at mx1-us-west.apache.org) with ESMTPS id B112424C66 for ; Wed, 20 May 2015 07:57:18 +0000 (UTC) Received: by igbpi8 with SMTP id pi8so127324763igb.0 for ; Wed, 20 May 2015 00:57:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wandisco.com; s=gapps; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=DQpYCN/q0rdIdwcd+RUlXsLppxIvpmBX3M8LVIzW7eA=; b=PDx9Tu2eQZAQnWp1cdTA5coBiSLhVBLcDCMeX6wOhsA9JFmeH60RS1CobmJORCsrp+ eXkj6rmVXKo01BPVUYd6GLz075qAwrKtREO3wB42gvIO5XdkxXI15AdhRWSyuBSeFhnm mgrg4KeiGxofSp83g905PBGFiXikbXX/c733c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=DQpYCN/q0rdIdwcd+RUlXsLppxIvpmBX3M8LVIzW7eA=; b=GBwi0l8FyoHlM0mBOelevR1D7Nps3RERPJC2Q5siP4RJSomGpqXpJgxqDv/KFtYQCo GvlDJEpFbPK7ofa5g44wcOKCoH3+dHkjWCCipPMyCvw3Ptx0ApFSU8FIFluC+68Dlr3Q Uf1zlRNLLsvZYJw1n2H6hOOrF0/p9bp/dlkIkKUwH+vj8wGJ95bZd62qWOLaJhKk2b2e EbzIjM7R31FnK1s5IQj/5Hafp9bDIv7YQD2Ee3HqvEKBMKYzLn3gXRRKRMhP9OEYcWEy 0JvfxJHeHuIS+rQfSOOTPco+NbjzkfVaRQcPD42susH318rX3rihvwMKYwK5kKnJeYaG Ui/Q== X-Gm-Message-State: ALoCoQl1toA1yBCtDikrW+PXfSKMNtje46Bw9YG51oeTQBb4WBHnXW/btxUQBcPHBGUGsWwglVXK MIME-Version: 1.0 X-Received: by 10.50.4.66 with SMTP id i2mr7237053igi.40.1432108638093; Wed, 20 May 2015 00:57:18 -0700 (PDT) Received: by 10.50.224.162 with HTTP; Wed, 20 May 2015 00:57:18 -0700 (PDT) In-Reply-To: References: <20150517231617.GB2214@tarsus.local2> Date: Wed, 20 May 2015 09:57:18 +0200 Message-ID: Subject: Re: [PATCH] fsfs7 index offset validation From: Stefan Fuhrmann To: Ivan Zhakov Cc: Daniel Shahaf , Subversion Development Content-Type: multipart/alternative; boundary=001a11c2a6f6a75f3e05167ec62d --001a11c2a6f6a75f3e05167ec62d Content-Type: text/plain; charset=UTF-8 On Mon, May 18, 2015 at 11:27 AM, Ivan Zhakov wrote: > On 18 May 2015 at 02:16, Daniel Shahaf wrote: > > Stefan, > > > > How about the following patch to sanity check the rev file footer? > > > [...] > > > > > The error looks like this: > > > > subversion/libsvn_fs_fs/rev_file.c:263, > > subversion/libsvn_fs_fs/low_level.c:212: > (apr_err=SVN_ERR_INCORRECT_PARAMS) > > svn: E200004: Invalid L2P offset in revision footer > > subversion/libsvn_subr/string.c:986: > (apr_err=SVN_ERR_INCORRECT_PARAMS) > > svn: E200004: Number '888' is out of range '[0, 546]' > > > It would be nice to have revision number or filename as a part of error > message. > Done in r1680476. -- Stefan^2. --001a11c2a6f6a75f3e05167ec62d Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On M= on, May 18, 2015 at 11:27 AM, Ivan Zhakov <ivan@visualsvn.com> wrote:
On 18 May 201= 5 at 02:16, Daniel Shahaf <d.s= @daniel.shahaf.name> wrote:
> Stefan,
>
> How about the following patch to sanity check the rev file footer?
>
[...]

>
> The error looks like this:
>
>=C2=A0 =C2=A0 =C2=A0subversion/libsvn_fs_fs/rev_file.c:263,
>=C2=A0 =C2=A0 =C2=A0subversion/libsvn_fs_fs/low_level.c:212: (apr_err= =3DSVN_ERR_INCORRECT_PARAMS)
>=C2=A0 =C2=A0 =C2=A0svn: E200004: Invalid L2P offset in revision footer=
>=C2=A0 =C2=A0 =C2=A0subversion/libsvn_subr/string.c:986: (apr_err=3DSVN= _ERR_INCORRECT_PARAMS)
>=C2=A0 =C2=A0 =C2=A0svn: E200004: Number '888' is out of range = '[0, 546]'
>
It would be nice to have revision number or filename as a part of er= ror message.

Done in r1680476.

<= /div>
-- Stefan^2.

--001a11c2a6f6a75f3e05167ec62d--