subversion-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Philip Martin <>
Subject Re: svn commit: r1680819 - /subversion/trunk/subversion/libsvn_fs_fs/revprops.c
Date Thu, 28 May 2015 13:01:02 GMT
Ivan Zhakov <> writes:

> Also I don't understand what do you mean "messy file-based code"? Imho
> code using svn_stream_write() that require pointer to length is more
> messy.

"messy" is not my word but the reason I prefer the stream code is that
we have been moving towards it.  Take this change:

-          SVN_ERR(svn_stream_printf(stream, pool, "%s\n", filename));
+          SVN_ERR(svn_io_file_write_full(file, filename, strlen(filename),
+                                         NULL, pool));
+          SVN_ERR(svn_io_file_putc('\n', file, pool));

We have svn_stream_printf() and it makes the stream code neater.  We
could fix that by introducing svn_io_file_printf().  Either we add all
the neat stream features to the file code or we attempt to move to the
stream code.

Philip Martin | Subversion Committer
WANdisco // *Non-Stop Data*

View raw message