subversion-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bert Huijben <>
Subject Re: svn commit: r1682265 - /subversion/trunk/subversion/libsvn_fs_fs/util.c
Date Thu, 28 May 2015 20:55:15 GMT
In this case the log message documented that it fixed ‘a problem on Windows’, which would
suggest at least some Windows testing


Correctly fsync() after renames in FSFS on Win32.  We must flush the disk
buffers after the rename, otherwise the metadata may not be persistent.
Moreover, if the rename is degraded to a copy by Win32, we won't even have
the complete file contents on disk without a buffer flush.


The original code worked just fine in 1.7 and 1.8 before this patch, so some explanation on
what problem is fixed, how to reproduce the problem and how this impacts performance would
be welcome.


Sent from Surface

From: Branko Čibej
Sent: ‎Thursday‎, ‎May‎ ‎28‎, ‎2015 ‎10‎:‎27‎ ‎PM
To: Ivan Zhakov
Cc:, Stefan Fuhrmann, Stefan Fuhrmann

On 28 May 2015 6:54 pm, "Ivan Zhakov" <> wrote:

> >> Did
> >> you able to reproduce data corruption on VM?
> >
> >
> > No. But I did not even try.
> >
> I really hope that you have tested your patch on Windows before commit.

I really hope you're joking. We've never required or expected testing on all platforms, from

-- Brane
View raw message