subversion-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel Shahaf <...@daniel.shahaf.name>
Subject Re: svn commit: r1679228 - /subversion/trunk/subversion/tests/libsvn_fs/fs-test.c
Date Sun, 17 May 2015 23:25:20 GMT
Ivan Zhakov wrote on Fri, May 15, 2015 at 14:31:13 +0300:
> On 14 May 2015 at 17:20, Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
> > ivan@apache.org wrote on Wed, May 13, 2015 at 15:37:18 -0000:
> >> * subversion/tests/libsvn_fs/fs-test.c
> >>   (freeze_and_commit): Use "/" instead of "" as PATH argument for
> >>    svn_fs_change_node_prop().
> >
> > What was the reason for the change?  The FS API explicitly accepts both
> > "" and "/" as valid spellings of the root directory.  (See svn_fs.h:1438)
> >
> You're right, but I think using canonical FS path is better for
> consistency: all other tests if this file uses canonical FS paths.

Actually, some tests use "" and others use "/".  I think that's exactly
right: both syntaxes are valid inputs and both of them have test coverage.

Mime
View raw message