subversion-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Branko ─îibej <>
Subject Re: 1.9 JavaHL memory leak in ISVNRemote#status
Date Fri, 24 Apr 2015 08:25:36 GMT
On 24.04.2015 10:15, Branko ─îibej wrote:
> There were two options for a fix:
>   * dispose of the object from the native code when it goes out of
>     scope; or,
>   * close the stream (causing an implicit disposal) from Java code.
> Picking the former would mean that the Java code must not close the
> stream, since doing so would result in a crash. Picking the latter
> means that forgetting to close the stream results in a memory leak.
> Faced with this dilemma, I decided that a potential memory leak with
> documented workaround is the less horrible option.

Of course it's clear that memory management in JavaHL needs a serious
overhaul, but this is not the time. Also, at some later date we may be
able to remove the requirement to close the stream whilst making closing
it always safe. Given the current JavaHL RA API, the only (Java) editor
implementation likely to exist for a while is the one within JavaHL
itself that's hidden under the hood of the status receiver.

-- Brane

View raw message