Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm
Precedence: bulk
Received-SPF: pass (nike.apache.org: domain of marc.strapetz@syntevo.com
 designates 80.67.29.23 as permitted sender)
Message-ID: <550C13F3.20704@syntevo.com>
Date: Fri, 20 Mar 2015 13:34:59 +0100
From: Marc Strapetz <marc.strapetz@syntevo.com>
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64;
 rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: Bert Huijben <bert@qqmail.nl>, dev@subversion.apache.org
Subject: Re: JavaHL: Exceptions in LogMessageCallback.singleMessage should
 abort the log immediately
References: <550704F9.4090306@syntevo.com>
 <000c01d06009$cfeef2e0$6fccd8a0$@qqmail.nl>
In-Reply-To: <000c01d06009$cfeef2e0$6fccd8a0$@qqmail.nl>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit

On 16.03.2015 17:54, Bert Huijben wrote:
>
>
>> -----Original Message-----
>> From: Marc Strapetz [mailto:marc.strapetz@syntevo.com]
>> Sent: maandag 16 maart 2015 17:30
>> To: dev@subversion.apache.org
>> Subject: JavaHL: Exceptions in LogMessageCallback.singleMessage should abort
>> the log immediately
>>
>> If e.g. a RuntimeException is thrown in
>> LogMessageCallback#singleMessage, it's not processed in
>> LogMessageCallback::singleMessage and the log is continued nevertheless:
>>
>> (1) At line 77 in LogMessageCallback.cpp, there should be returned an
>> appropriate error code.
>>
>> (2) After line 122, JNIUtil::isJavaExceptionThrown() should be called
>> and there should be returned an appropriate error code.
>>
>> In both cases, the returned error code should result in stopping the
>> low-level log; rethrowing the Exception in RemoteSession::getLog won't
>> be necessary, as this can be established easily from within client code
>> itself.
>
> This is a common problem that applies to almost all callbacks in JavaHL in <= 1.9.
>
> A fix for this generic problem has been applied to trunk in r1664938 (further tweaks/extensions in 1664939,1664940,1664978,1664984).
>
> This introduces some behavior changes (such as the one you noted), so backporting needs discussion here. Thanks for starting the discussion ;-)

As JavaHL was reworked significantly for Subversion 1.9, is there a 
possibility to get this change backported?

-Marc