Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm
Precedence: bulk
Received-SPF: pass (athena.apache.org: domain of vega.james@gmail.com
 designates 209.85.192.54 as permitted sender)
Sender: James McCoy <vega.james@gmail.com>
Date: Fri, 20 Mar 2015 22:25:19 -0400
From: James McCoy <jamessan@debian.org>
To: Philip Martin <philip.martin@wandisco.com>
Cc: dev@subversion.apache.org
Subject: Re: Segfault in Perl bindings when commit touches a large number of
 files
Message-ID: <20150321022519.GA1499@freya.jamessan.com>
Mail-Followup-To: James McCoy <jamessan@debian.org>,
	Philip Martin <philip.martin@wandisco.com>,
	dev@subversion.apache.org
References: <20150318032038.GB31550@freya.jamessan.com>
 <87egomz7h7.fsf@wandisco.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="Kj7319i9nmIyA2yE"
Content-Disposition: inline
In-Reply-To: <87egomz7h7.fsf@wandisco.com>
User-Agent: Mutt/1.5.23 (2014-03-12)


--Kj7319i9nmIyA2yE
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Mar 18, 2015 at 02:49:08PM +0000, Philip Martin wrote:
> I also see that.  Given that Perl has realloc'd some memory I suppose
> it might be a reference counting bug in Subversion's XS code.
>=20
> Or perhaps the bug might be this code in svn_types.swg:
>=20
> %typemap(argout) unsigned char *result_digest {
>   /* FIXME: This code is clearly buggy. The return value of sv_newmortal()
>      is immediately overwritten by the return value
>      of svn_swig_pl_from_md5(). */
>     ST(argvi) =3D sv_newmortal();
>     ST(argvi++) =3D svn_swig_pl_from_md5($1);
> }
> #endif

Indeed.  Reading through some Perl documentation, the original commit,
and svn_swig_pl_from_md5, I don't see why the svn_newmortal() call is
there.  svn_swig_pl_from_md5 already makes its return value mortal, so
this is just allocating and overwriting a new SV*.

Removing this resolves the crash and reduces the amount of
(de)allocations.

Cheers,
--=20
James
GPG Key: 4096R/331BA3DB 2011-12-05 James McCoy <jamessan@debian.org>

--Kj7319i9nmIyA2yE
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQJ8BAEBCgBmBQJVDNaIXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ5MUJGQkY0RDY5NTZCRDVERjdCNzJEMjNE
RkU2OTFBRTMzMUJBM0RCAAoJEN/mka4zG6Pbt5MP/jVqFDDNXlsdtgg+gkjbhsmj
Kkn9KjwZxBVnl8G+pjqoVaJJro0rWKzF1OJ4Cm5XMz79YFtwhLtdTLVH/yNbbHVz
P+jcpasIqvbJnII3Wr/l0U+eg4UHKGoitSMqSZkoY8p/TamfNz0zmx5SZLL1Ovj6
C6L0ork3jYNvYOf7jOKWsFNmcfnDtsOJpzFdrUlaK4W8Bi8oU4u9pdNFEkGZl9D4
EApdxMOZYa83jQktjHOzTqPxaQ8XozS9t85ZuWA4dnlkWtTyo1zlqEarf6DaVGuo
sQ3/ufzrwKL1Yd5Qtrscn9OeJlcLKs0AFqPEo3ZNO8u+c0e3zTSwc96/47cot2sk
EznCa+tP54lC12oLHOvOnLFeUywUoIYw4ho9jgYDO749824SOvHNdRxLJUER7s+b
CM5J77Fyv9mlBMpdlRGmdoOsxwV9E2LrGrihqQd1asDmBXWyybDfRUnEDP8vXDXS
Vx8pc90ScOXqiibOq39MsBuNNpTjhTmWCeWv5pQn76olQ9a9x7OHN5j+qIxcpEge
+s1FFpf2PergNbEdpZQsZFMoo7njNU5P+Cd2Bxg5PpIOEHlp5E4+j+HpKASXSccG
HB+QGGodi8I7P65yugScgiDnKV8LIA65tb3cW/q3bD8YGNVWWIO98pEIjtBSf53S
PPbB52b5vCfvI91mEMVZ
=xVGe
-----END PGP SIGNATURE-----

--Kj7319i9nmIyA2yE--