subversion-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ivan Zhakov <i...@visualsvn.com>
Subject Re: svn commit: r1665853 - /subversion/trunk/subversion/libsvn_diff/diff_file.c
Date Thu, 12 Mar 2015 12:04:30 GMT
On 12 March 2015 at 14:33, Branko Čibej <brane@wandisco.com> wrote:
> On 12.03.2015 09:27, Branko Čibej wrote:
>
> On 12.03.2015 08:49, Bert Huijben wrote:
>
> This resolves several signed compared to unsigned warnings on Windows.
>
> It is nice to fix warnings for some favorite compiler, but there are still >
> 200 warnings left on Windows, especially on cases that assume int and size_t
> variants have identical length, which doesn’t hold on Win64.
>
>
[...]

> In general, however, when fixing a warning it's often a good
> idea to consider the semantics of the surrounding code, not just make a
> minimal change to make the compiler shot up.
>
+1. It's better to leave compile time warning, then fixing then just
silence them. With compile time warnings we may fix the problem
properly in future.


-- 
Ivan Zhakov

Mime
View raw message