subversion-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bert Huijben" <b...@qqmail.nl>
Subject RE: [Patch] Expression support for SVNPath and SVNParentPath
Date Thu, 26 Feb 2015 20:02:14 GMT


> -----Original Message-----
> From: Philip Martin [mailto:philip.martin@wandisco.com]
> Sent: donderdag 26 februari 2015 20:13
> To: Bert Huijben
> Cc: Graham Leggett; 'Subversion Development'
> Subject: Re: [Patch] Expression support for SVNPath and SVNParentPath
> 
> Bert Huijben <bert@qqmail.nl> writes:
> 
> > The ‘}’ is matched by that at the end of the if lines in both
> > blocks. (Not really our common code style)
> 
> The problem is that there is a '{' before the #if and a '}' inside the
> #if but no '}' in the #else.  I think #if code compiles and the #else
> code fails.
> 
> >> +  if (arg2) {
> >> +#if AP_MODULE_MAGIC_AT_LEAST(20111025,3)
> >> +    const char *expr_err = NULL;
> >> +
> >> + conf->fs_path->expr = ap_expr_parse_cmd(cmd, arg2,
> >> AP_EXPR_FLAG_STRING_RESULT,
> >> +            &expr_err, NULL);
> >> +    if (expr_err) {

Did you see the '{' ^^^ here?

> >> +      apr_pstrcat(cmd->temp_pool,
> >> +                  "Cannot parse expression in SVNPath: ",
> >> +                  expr_err, NULL);
> >
> > expr_err contains the error message if parsing fails but it appears to
> > be discared.
> >
> >> +    }

Which is closed here?

	Bert


Mime
View raw message