Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm
Precedence: bulk
Received-SPF: pass (athena.apache.org: domain of philip.martin@wandisco.com
 designates 74.125.82.52 as permitted sender)
From: Philip Martin <philip.martin@wandisco.com>
To: Lieven Govaerts <lgo@mobsol.be>
Cc: "serf-dev\@googlegroups.com" <serf-dev@googlegroups.com>,
  pierre.viret@postfinance.ch,
  Subversion Development <dev@subversion.apache.org>
Subject: Re: [serf-dev] Re: [PATCH] Serf crash on spurious data between
 responses
References: <1434486319.700608.1420529505682.JavaMail.postmaster@post.ch>
	<878uhgb03r.fsf@ntlworld.com>
	<1332240118.440483.1420549488045.JavaMail.postmaster@post.ch>
	<87y4pg9fe7.fsf@ntlworld.com>
	<2123531229.447826.1420556241367.JavaMail.postmaster@post.ch>
	<87h9w2d7ic.fsf@ntlworld.com>
	<472712693.57162.1420703794232.JavaMail.postmaster@post.ch>
	<87ioghxuqb.fsf@ntlworld.com> <87a91txmp8.fsf@ntlworld.com>
	<8761chxjhu.fsf@ntlworld.com> <87y4pdw3nc.fsf_-_@ntlworld.com>
	<87d26n8r43.fsf_-_@ntlworld.com> <87r3v2260i.fsf@ntlworld.com>
	<CANvU9sffh07exFK=069HUZvWwbpy4L2yzgCc1Uc7ea=CEjqLRQ@mail.gmail.com>
Date: Mon, 12 Jan 2015 11:22:34 +0000
In-Reply-To: 
 <CANvU9sffh07exFK=069HUZvWwbpy4L2yzgCc1Uc7ea=CEjqLRQ@mail.gmail.com>
	(Lieven Govaerts's message of "Mon, 12 Jan 2015 11:41:06 +0100")
Message-ID: <87oaq4ckg5.fsf@ntlworld.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.4 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii

Lieven Govaerts <lgo@mobsol.be> writes:

> You're trying to capture the situation where serf has:
> - finished writing a request ( req_bkt == NULL && writing_started )
> - has no more requests in the pending queue
> - and receives actual bytes of data.
> Right?
>
> Looks like your patch is a correct way to fix the problem. Some
> comments would be welcome, and if you have the time a test.

I'm not familiar with serf's testsuite.  The scenario:

  - client sends first request
  - server sends response
  - server sends extra data, say '\n'
  - client handles first request
  - client creates a second request
  - client calls serf to send second, pipelined, request
  - serf reads extra data
  - serf attempts to pass the extra data to client's callbacks

At this point serf has not called setup_request so although the client
has created a request is not ready to receive data.  How do I go about
writing such a test?

-- 
Philip Martin | Subversion Committer
WANdisco // *Non-Stop Data*