subversion-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Fuhrmann <stefan.fuhrm...@wandisco.com>
Subject Re: [RFC] Refining our naming rules
Date Mon, 05 Jan 2015 13:08:43 GMT
On Sun, Jan 4, 2015 at 8:12 PM, Branko Čibej <brane@wandisco.com> wrote:

> On 02.01.2015 23:04, Branko Čibej wrote:
> > On 02.01.2015 13:31, Stefan Fuhrmann wrote:
> >> Now there are only two points left
> >>
> >> * Be explicit in our coding style guide about the mandatory
> >>   svn_ prefix in all non-static identifiers.
> > If this is not already stated explicitly in HACKING, it should be. You
> > just volunteered to check and fix. :)
> >
> >> * Don't shorten library names. No need to fix that for older
> >>   FS but get it right in FSX.
> > Ack.
>
>
> On second thoughts, consider what we're doing on the authzperf branch:
>
>   * "local" symbols that are not exported (struct and enum names and
>     typedefs) are simply called authz_something_t;
>   * "local" function names are svn_authz__something, even though there's
>     no "libsvn_authz" or svn_authz.h. The symbol name should indicate
>     grouping by logical module rather than by library name; we do this
>     all over the place in libsvn_subr, and it should be just fine in
>     other libraries (IMO, as long as module implementations aren't split
>     amongst several libraries).
>

Makes sense but I need to muse about this for a bit.

-- Stefan^2.

Mime
View raw message