subversion-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Branko ─îibej <br...@wandisco.com>
Subject Re: svn commit: r1642813 - in /subversion/trunk/subversion/bindings/swig: include/svn_types.swg python/libsvn_swig_py/swigutil_py.c python/libsvn_swig_py/swigutil_py.h python/svn/core.py python/svn/repos.py python/tests/repository.py svn_repos.i
Date Thu, 18 Dec 2014 06:00:29 GMT
On 18.12.2014 03:48, Alexey Neyman wrote:
> Any objections to the attached fix?
>
>> + def _assertListEqual(self, l1, l2):
>> + """Poor man's replacement for assertListEqual, available in Python
>> 2.7+"""
>> + self.assertEqual(len(l1), len(l2))
>> + for i in range(0, len(l1)):
>> + self.assertEqual(l1[i], l2[i])


Perhaps just:

    map(self.assertEqual, l1, l2)


and I would prefer subclassing to instance method injection.

-- Brane

Mime
View raw message