Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm
Precedence: bulk
Received-SPF: pass (nike.apache.org: domain of brane@wandisco.com designates
 74.125.82.52 as permitted sender)
Message-ID: <5450A909.3070400@wandisco.com>
Date: Wed, 29 Oct 2014 09:44:57 +0100
From: =?UTF-8?B?QnJhbmtvIMSMaWJlag==?= <brane@wandisco.com>
Organization: WANdisco
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10;
 rv:24.0) Gecko/20100101 Thunderbird/24.6.0
MIME-Version: 1.0
To: Subversion Development <dev@subversion.apache.org>
Subject: Re: svn commit: r1634875 -
 /subversion/trunk/subversion/libsvn_fs_fs/revprops.c
References: <20141028131930.B841023888A6@eris.apache.org>
In-Reply-To: <20141028131930.B841023888A6@eris.apache.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 28.10.2014 14:19, stefan2@apache.org wrote:
> Author: stefan2
> Date: Tue Oct 28 13:19:30 2014
> New Revision: 1634875
>
> URL: http://svn.apache.org/r1634875
> Log:
> Speed up packed revprop access by tuning the manifest file parser.

[...]

> +/* Return the minimum length of any packed revprop file name in REVPROPS. */
> +static apr_size_t
> +get_min_filename_len(packed_revprops_t *revprops)
> +{
> +  char number_buffer[SVN_INT64_BUFFER_SIZE];
> +
> +  /* The revprop filenames have the format <REV>.<COUNT> - with <REV> being
> +   * at least the first rev in the shard and <COUNT> having at least one
> +   * digit.  Thus, the minimum is 2 + #decimal places in the start rev.
> +   */
> +  return svn__i64toa(number_buffer, revprops->manifest_start) + 2;
> +}

Are you absolutely sure this is correct? According to the comment, you
should be returning

    strlen(svn_i64toa(...)) + 2

As it is, you end up allocating buffers that are orders of magnitude
larger than necessary.

-- Brane