Return-Path: X-Original-To: apmail-subversion-dev-archive@minotaur.apache.org Delivered-To: apmail-subversion-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8B93D1133D for ; Tue, 2 Sep 2014 06:24:45 +0000 (UTC) Received: (qmail 56479 invoked by uid 500); 2 Sep 2014 06:24:43 -0000 Delivered-To: apmail-subversion-dev-archive@subversion.apache.org Received: (qmail 56423 invoked by uid 500); 2 Sep 2014 06:24:43 -0000 Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@subversion.apache.org Received: (qmail 56413 invoked by uid 99); 2 Sep 2014 06:24:42 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Sep 2014 06:24:42 +0000 X-ASF-Spam-Status: No, hits=1.5 required=5.0 tests=HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of brane@wandisco.com designates 209.85.212.182 as permitted sender) Received: from [209.85.212.182] (HELO mail-wi0-f182.google.com) (209.85.212.182) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Sep 2014 06:24:15 +0000 Received: by mail-wi0-f182.google.com with SMTP id z2so7174221wiv.9 for ; Mon, 01 Sep 2014 23:24:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wandisco.com; s=gapps; h=message-id:date:from:organization:user-agent:mime-version:to:cc :subject:references:in-reply-to:content-type; bh=eKg+jvwbyfDY4ff67A95pmrAjy0qq7Hzmxk3DR6DTGI=; b=KR+oINFz/xy8GVVux2gCXJ41ktBUSbUCI9lJO/nEcU2t4yrg0+mrQ7IalthwVe9vgH 8aBXlHKHMkg8IDgSloV+VKRnoOArgbOMVyQhL5Tu8obZpKF7mxR1GwsLaggoGSHiQ8cU u5z4VC1eSLdRExYrzjhAYCVaDplb9HM8zmeQU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:organization:user-agent :mime-version:to:cc:subject:references:in-reply-to:content-type; bh=eKg+jvwbyfDY4ff67A95pmrAjy0qq7Hzmxk3DR6DTGI=; b=i4MGvHA7l5rRv38ooZ9XUElfC/BWx+ajRG1LHAntXp2bbfwpWtZ2VdIp6yzN/fm+OX eoPMRusSXXYZ9pqWnxBf0P+jlJZ50g4z7K0oLPT77cIv9ZXzNc7shQ6ajdylsy9cV4Je n0yFY3m4EkMpM27j0uJjoxmpvLrn52U+63RjF/KTq55E/9B81kW7IB27YC92CUOaW+tS 74DcS1gf7wMlxzwN+VQgTI9AWZ4k7pElTBKx4on+Bs+kzjtOZaR4MMvuEPpcPwX56RYO ZUU8GoUTuqaxQESBBITcPR51POL7j4Jgw9tYltKdTDSA93fm53WOx0L/gNUt1VvrNcU2 qkxQ== X-Gm-Message-State: ALoCoQlJgMGQ0yXKuenw/cTx0v2JLfdazq3d1m/NmSqNNymiyNSrMgW3WSgLGfeoakZXGW63LXMO X-Received: by 10.194.187.241 with SMTP id fv17mr37435195wjc.13.1409639054599; Mon, 01 Sep 2014 23:24:14 -0700 (PDT) Received: from zulu.local (cpe-90-157-246-198.dynamic.amis.net. [90.157.246.198]) by mx.google.com with ESMTPSA id la2sm7242135wjb.5.2014.09.01.23.24.13 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Mon, 01 Sep 2014 23:24:13 -0700 (PDT) Received: from zulu.local (localhost [127.0.0.1]) by zulu.local (Postfix) with ESMTP id 09270C6C3A47; Tue, 2 Sep 2014 08:24:12 +0200 (CEST) Message-ID: <5405628B.3020501@wandisco.com> Date: Tue, 02 Sep 2014 08:24:11 +0200 From: =?UTF-8?B?QnJhbmtvIMSMaWJlag==?= Organization: WANdisco User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Stefan Fuhrmann CC: Subversion Development Subject: Re: svn commit: r1621387 - in /subversion/branches/authzperf/subversion/libsvn_repos: authz.c authz.h authz_parse.c References: <20140829210326.32CB82388868@eris.apache.org> <54010FE5.3040507@wandisco.com> <5402371A.7040703@wandisco.com> <54042BF3.4030804@wandisco.com> In-Reply-To: Content-Type: multipart/alternative; boundary="------------080807030903000305010801" X-Virus-Checked: Checked by ClamAV on apache.org This is a multi-part message in MIME format. --------------080807030903000305010801 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 01.09.2014 21:48, Stefan Fuhrmann wrote: > > Stefan, I went through the docs (and commits); there are a > couple new > comments in the doc, one is a minor nit, the other affects the > rights > lookup workflow. > > > We already talked about that shortcut. > > I'll give it a go tomorrow. I'm about to commit a new function in authz_info.c, called svn_authz__get_global_rights; it should do the global access resolving part. > IIUC, you already removed the foo/** to foo/* > > normalization from the code? > > > Yes, at least that was the intent. I might have missed or broken > something, though. > > Parser states can be non-obvious at times. authz-test says trailing ** remains unchanged, so I guess you found the right place. -- Brane --------------080807030903000305010801 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit
On 01.09.2014 21:48, Stefan Fuhrmann wrote:

Stefan, I went through the docs (and commits); there are a couple new
comments in the doc, one is a minor nit, the other affects the rights
lookup workflow.

We already talked about that shortcut.
I'll give it a go tomorrow.

I'm about to commit a new function in authz_info.c, called svn_authz__get_global_rights; it should do the global access resolving part.

 IIUC, you already removed the foo/** to foo/*
normalization from the code?

Yes, at least that was the intent. I might have missed or broken something, though.
Parser states can be non-obvious at times.

authz-test says trailing ** remains unchanged, so I guess you found the right place.

-- Brane

--------------080807030903000305010801--