Return-Path: X-Original-To: apmail-subversion-dev-archive@minotaur.apache.org Delivered-To: apmail-subversion-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6054511AAF for ; Tue, 12 Aug 2014 17:23:19 +0000 (UTC) Received: (qmail 28305 invoked by uid 500); 12 Aug 2014 17:23:14 -0000 Delivered-To: apmail-subversion-dev-archive@subversion.apache.org Received: (qmail 28264 invoked by uid 500); 12 Aug 2014 17:23:14 -0000 Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@subversion.apache.org Received: (qmail 27876 invoked by uid 99); 12 Aug 2014 17:23:13 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 12 Aug 2014 17:23:13 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of ivan@visualsvn.com designates 209.85.216.179 as permitted sender) Received: from [209.85.216.179] (HELO mail-qc0-f179.google.com) (209.85.216.179) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 12 Aug 2014 17:23:09 +0000 Received: by mail-qc0-f179.google.com with SMTP id m20so3040956qcx.24 for ; Tue, 12 Aug 2014 10:22:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=visualsvn.com; s=google; h=mime-version:from:date:message-id:subject:to:content-type; bh=DC9/uorrQLPbY/S/5Zmxcn+DRocq5KU/VC+6J3rrtNs=; b=UusjJ+jlkfSLFSBeYTz08wi9ngpxqmS0DupvyeEBgEdG+AD1SJ09NfmLakeLCcrdjG 79pI1BlZXXaJZRPV+rWshfeappHvtl3uFxAmgoQ2RDH2d7uMoBCMqcS50OZGOqeRCns5 tv/6N4G3LCmp3skA6EbiijejunBAyfVKhM6d8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:from:date:message-id:subject:to :content-type; bh=DC9/uorrQLPbY/S/5Zmxcn+DRocq5KU/VC+6J3rrtNs=; b=BOVR8ez0/R/iNRb/LEnM6iaNNMwoW49A2zqypegVok4e/7tUKnrsQaEKGOOpbpXyc6 vScK2oTKXRHfQbeTV87AVvNPIBWk7Fwe+8I917HK9K3algQ1moFmGtmmy0f6ApvF2FNC AIPgqTqJq7ONCyHjG9LIN/LDXsuy5bYGqWUOYCBmpwZpfdw/K2VbkOs4uTYOtvMVaWSD IvVsN8HakX7aYHsTCqWt5sReGlI8huEC/ZJ1EbaTJszKymK82TqGtgNbz2qRnY0lRWnT ng++xQvuQ438dWWLRkkUwy+zEFcL5IcNp2Qkb93RQG0E0AluIohba0EDX5KPEEaT9kYO B5tw== X-Gm-Message-State: ALoCoQnnvOXIn408GFxHBAdeyxETRkhqmC60A9cXWKQCsslfsS5YdSQ7PaBrdwikikZp48Fq7JgF X-Received: by 10.224.123.8 with SMTP id n8mr8972821qar.40.1407864168728; Tue, 12 Aug 2014 10:22:48 -0700 (PDT) MIME-Version: 1.0 Received: by 10.140.22.35 with HTTP; Tue, 12 Aug 2014 10:22:28 -0700 (PDT) From: Ivan Zhakov Date: Tue, 12 Aug 2014 21:22:28 +0400 Message-ID: Subject: Possible deadlock in named atomic infrastructure used by revprop caching To: stefan.fuhrmann@wandisco.com, Subversion Development Content-Type: text/plain; charset=UTF-8 X-Virus-Checked: Checked by ClamAV on apache.org Stefan, I've noticed another severe issue in named atomic infrastructure used by revprop caching code while reviewing r1611379 fix: svn_atomic_namespace__create() doesn't release file lock and process-wide mutex (!) on error in libsvn_subr\named_atomic.c:446. Which is basically mean that server will be deadlocked if *any* of named atomic shared file contains some invalid data. -- Ivan Zhakov CTO | VisualSVN | http://www.visualsvn.com