subversion-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Julian Foad <julianf...@btopenworld.com>
Subject Re: Wunused-but-set-parameter warning in svn_wc_get_diff_editor6
Date Fri, 22 Aug 2014 10:52:02 GMT
Philip Martin wrote:
> ../src/subversion/libsvn_wc/deprecated.c: In function 
> 'svn_wc_get_diff_editor6':
> ../src/subversion/libsvn_wc/deprecated.c:1991:39: warning: parameter 
> 'ignore_ancestry' set but not used [-Wunused-but-set-parameter]
> 
> It was added in 1569697.  Is this bit redundant or is something missing
> from the compatibility function?

Bert, Philip,

There seems to be more than one problem in that function.

The 'ignore_ancestry' flag should probably be passed to svn_wc__get_diff_editor(..., ignore-ancestry=ignore_ancestry,
...) instead of passing (..., ignore_ancestry=use_git_diff_format, ...). But then where should
'use_git_diff_format' be used?

The 'reverse' flag is used twice: once to construct a reversing filter that will reverse the
results; and then again the flag is passed to the diff generator to tell it to generate reversed
results. Wouldn't this cause a double-reversal?


I haven't tried to debug it.

- Julian

Mime
View raw message