Return-Path: X-Original-To: apmail-subversion-dev-archive@minotaur.apache.org Delivered-To: apmail-subversion-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BB47B11FC0 for ; Thu, 12 Jun 2014 08:01:45 +0000 (UTC) Received: (qmail 47653 invoked by uid 500); 12 Jun 2014 08:01:45 -0000 Delivered-To: apmail-subversion-dev-archive@subversion.apache.org Received: (qmail 47588 invoked by uid 500); 12 Jun 2014 08:01:44 -0000 Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@subversion.apache.org Received: (qmail 47581 invoked by uid 99); 12 Jun 2014 08:01:44 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 12 Jun 2014 08:01:44 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of bert@qqmail.nl designates 74.125.82.174 as permitted sender) Received: from [74.125.82.174] (HELO mail-we0-f174.google.com) (74.125.82.174) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 12 Jun 2014 08:01:42 +0000 Received: by mail-we0-f174.google.com with SMTP id u57so851901wes.33 for ; Thu, 12 Jun 2014 01:01:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qqmail.nl; s=google; h=from:to:references:in-reply-to:subject:date:message-id:mime-version :content-type:content-transfer-encoding:thread-index :content-language; bh=rixPjRvwBNEaRgEnmfHPum/zmooMYM+kblMxzN5ySng=; b=b6hZiny/MmBlZ/r/Qg+p297/3psmQvBTGELuG3ms3aB7woJPdj60211SxLb05CYCcz pYdYVLon9Wn5vyizBrvNq4uZ/wpURF1obbR1LwK0nN9NfvMKsn+ZddM7sZEcxoTZUEaS sr9QiopI91ltf2agNRbmly8AMYoKiG92/KXsE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:references:in-reply-to:subject:date :message-id:mime-version:content-type:content-transfer-encoding :thread-index:content-language; bh=rixPjRvwBNEaRgEnmfHPum/zmooMYM+kblMxzN5ySng=; b=eQrMDLBxc/6b8hVFVdn9Pzu7vU0/ruwnc/szq+0+6Y8BE+8TOYcao1jRzvL+nxJ3Jc XgPbUb7ZUIFhrs2rrTQ/SbzZnrBwCuWEFQ7KZeG7dWspIMf08M3LTsg6Cbt5i5Z9HjL2 WLqohyPOCOUNN+kjNhELAFTLw4MEpMhttaHDgwh357UC0NfYL3TERn7MylWJsSRWNJoK NCbW0gWFbQoGuThgtjmwbC9U574jnJmUZ8jTap+w/qAHZ3vyrtzJSjb7XE/tWuolhA8p k2BrhdNaDN+9ItpBIPdxCb0vHa40A5EA6pdJh7H2qiG1ygQFKsax003wIynHovRRKYXG k1dQ== X-Gm-Message-State: ALoCoQlKbjMd6zZcvixIcNzQCHdfDZR6ng1HZL263AoK4NrvHmHAovwDBaXVzOibtD9cURxkFAj3 X-Received: by 10.194.89.168 with SMTP id bp8mr59140322wjb.73.1402560077974; Thu, 12 Jun 2014 01:01:17 -0700 (PDT) Received: from i72600 ([2001:610:66e:0:a1fe:7b28:1850:b511]) by mx.google.com with ESMTPSA id i4sm3217938eeg.28.2014.06.12.01.01.16 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 12 Jun 2014 01:01:17 -0700 (PDT) From: "Bert Huijben" To: "'Gabriela Gibson'" , "'Subversion Development'" References: <5398DA86.7070407@gmail.com> In-Reply-To: <5398DA86.7070407@gmail.com> Subject: RE: [PATCH] change of variable name: 'diff_cmd_baton' to 'dwi' in subversion/libsvn_client/diff.c Date: Thu, 12 Jun 2014 10:01:11 +0200 Message-ID: <04e601cf8614$7b670250$723506f0$@qqmail.nl> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 15.0 Thread-Index: AQHzvWIPbVr6/2EXMwfGXt1pM6d96ZskrTEg Content-Language: nl X-Virus-Checked: Checked by ClamAV on apache.org > -----Original Message----- > From: Gabriela Gibson [mailto:gabriela.gibson@gmail.com] > Sent: donderdag 12 juni 2014 00:39 > To: Subversion Development > Subject: [PATCH] change of variable name: 'diff_cmd_baton' to 'dwi' in > subversion/libsvn_client/diff.c > > Whilst rooting around, I saw that the local variable 'diff_cmd_baton' > was changed to the type diff_writer_into_t and in most other placed had > the name 'dwi'. > > I changed all the local instances in subversion/libsvn_client/diff.c to > match the new naming scheme. > > Gabriela > > [[[ > > Change all occurrences of 'diff_cmd_baton' to 'dwi'. > > * subversion/libsvn_client/diff.c > (just_paths_for_diff_labels), > (diff_props_changed), > (svn_client_diff6), > (svn_client_diff_peg6): changed local variable diff_cmd_baton to > dwi throughout. > > ]]] +1 Feel free to commit this patch with the addition of [[ Approved by: rhuijben ]] I just checked trunk/COMMITTERS and found that you aren't in there. Can you add yourself as partial committer for gtest in a separate commit? Thanks, Bert